fix(model)!: base model should recursively store coerced base models (#165)

Author: stainless-app[bot]

lib/orb/base_model.rb

@@ -913,6 +913,13 @@ def known_fields
         @known_fields ||= (self < Orb::BaseModel ? superclass.known_fields.dup : {})
       end
 
+      # @api private
+      #
+      # @return [Hash{Symbol=>Symbol}]
+      def reverse_map
+        @reverse_map ||= (self < Orb::BaseModel ? superclass.reverse_map.dup : {})
+      end
+
       # @api private
       #
       # @return [Hash{Symbol=>Hash{Symbol=>Object}}]
@@ -956,7 +963,7 @@ def defaults = (@defaults ||= {})
         fallback = info[:const]
         defaults[name_sym] = fallback if required && !info[:nil?] && info.key?(:const)
 
-        key = info.fetch(:api_name, name_sym)
+        key = info[:api_name]&.tap { reverse_map[_1] = name_sym } || name_sym
         setter = "#{name_sym}="
 
         if known_fields.key?(name_sym)
@@ -1213,7 +1220,21 @@ def deconstruct_keys(keys)
     def initialize(data = {})
       case Orb::Util.coerce_hash(data)
       in Hash => coerced
-        @data = coerced.transform_keys(&:to_sym)
+        @data = coerced.to_h do |key, value|
+          name = key.to_sym
+          mapped = self.class.reverse_map.fetch(name, name)
+          type = self.class.fields[mapped]&.fetch(:type)
+          stored =
+            case [type, value]
+            in [Class, Hash] if type <= Orb::BaseModel
+              type.new(value)
+            in [Orb::ArrayOf, Array] | [Orb::HashOf, Hash]
+              type.coerce(value)
+            else
+              value
+            end
+          [name, stored]
+        end
       else
         raise ArgumentError.new("Expected a #{Hash} or #{Orb::BaseModel}, got #{data.inspect}")
       end

rbi/lib/orb/base_model.rbi

@@ -454,6 +454,11 @@ module Orb
       def known_fields
       end
 
+      # @api private
+      sig { returns(T::Hash[Symbol, Symbol]) }
+      def reverse_map
+      end
+
       # @api private
       sig { returns(T::Hash[Symbol, T.all(Orb::BaseModel::KnownFieldShape, {type: Orb::Converter::Input})]) }
       def fields

sig/orb/base_model.rbs

@@ -173,6 +173,8 @@ module Orb
     def self.known_fields: -> ::Hash[Symbol, (Orb::BaseModel::known_field
     & { type_fn: (^-> Orb::Converter::input) })]
 
+    def self.reverse_map: -> ::Hash[Symbol, Symbol]
+
     def self.fields: -> ::Hash[Symbol, (Orb::BaseModel::known_field
     & { type: Orb::Converter::input })]
 

test/orb/base_model_test.rb

@@ -222,6 +222,20 @@ def test_nested_model_dump
     end
   end
 
+  class M4 < M2
+    required :c, M1
+    required :d, Orb::ArrayOf[M4]
+    required :e, M2, api_name: :f
+  end
+
+  def test_model_to_h
+    model = M4.new(a: "wow", c: {}, d: [{}, 2, {c: {}}], f: {})
+    assert_pattern do
+      model.to_h => {a: "wow", c: M1, d: [M4, 2, M4 => child], f: M2}
+      assert_equal({c: M1.new}, child.to_h)
+    end
+  end
+
   A3 = Orb::ArrayOf[A1]
 
   class M3 < M1