fix: pages should be able to accept non-converter models (#176)

stainless-app[bot] · stainless-app[bot] · commit 99b36e212b42 · 2025-03-21T12:53:45.000Z
diff --git a/lib/orb/page.rb b/lib/orb/page.rb
@@ -43,7 +43,7 @@ def initialize(client:, req:, headers:, page_data:)
 
       case page_data
       in {data: Array | nil => data}
-        @data = data&.map { model.coerce(_1) }
+        @data = data&.map { Orb::Converter.coerce(model, _1) }
       else
       end
 
diff --git a/test/orb/resources/alerts_test.rb b/test/orb/resources/alerts_test.rb
@@ -59,6 +59,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::Alert
     end
diff --git a/test/orb/resources/coupons/subscriptions_test.rb b/test/orb/resources/coupons/subscriptions_test.rb
@@ -11,6 +11,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::Subscription
     end
diff --git a/test/orb/resources/coupons_test.rb b/test/orb/resources/coupons_test.rb
@@ -35,6 +35,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::Coupon
     end
diff --git a/test/orb/resources/credit_notes_test.rb b/test/orb/resources/credit_notes_test.rb
@@ -41,6 +41,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::CreditNote
     end
diff --git a/test/orb/resources/customers/balance_transactions_test.rb b/test/orb/resources/customers/balance_transactions_test.rb
@@ -34,6 +34,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::Customers::BalanceTransactionListResponse
     end
diff --git a/test/orb/resources/customers/credits/ledger_test.rb b/test/orb/resources/customers/credits/ledger_test.rb
@@ -11,6 +11,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::Customers::Credits::LedgerListResponse
     end
@@ -445,6 +447,8 @@ def test_list_by_external_id
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::Customers::Credits::LedgerListByExternalIDResponse
     end
diff --git a/test/orb/resources/customers/credits/top_ups_test.rb b/test/orb/resources/customers/credits/top_ups_test.rb
@@ -40,6 +40,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::Customers::Credits::TopUpListResponse
     end
@@ -115,6 +117,8 @@ def test_list_by_external_id
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::Customers::Credits::TopUpListByExternalIDResponse
     end
diff --git a/test/orb/resources/customers/credits_test.rb b/test/orb/resources/customers/credits_test.rb
@@ -11,6 +11,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::Customers::CreditListResponse
     end
@@ -36,6 +38,8 @@ def test_list_by_external_id
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::Customers::CreditListByExternalIDResponse
     end
diff --git a/test/orb/resources/customers_test.rb b/test/orb/resources/customers_test.rb
@@ -81,6 +81,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::Customer
     end
diff --git a/test/orb/resources/dimensional_price_groups_test.rb b/test/orb/resources/dimensional_price_groups_test.rb
@@ -54,6 +54,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::DimensionalPriceGroup
     end
diff --git a/test/orb/resources/events/backfills_test.rb b/test/orb/resources/events/backfills_test.rb
@@ -39,6 +39,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::Events::BackfillListResponse
     end
diff --git a/test/orb/resources/invoices_test.rb b/test/orb/resources/invoices_test.rb
@@ -135,6 +135,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::Invoice
     end
diff --git a/test/orb/resources/items_test.rb b/test/orb/resources/items_test.rb
@@ -45,6 +45,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::Item
     end
diff --git a/test/orb/resources/metrics_test.rb b/test/orb/resources/metrics_test.rb
@@ -55,6 +55,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::BillableMetric
     end
diff --git a/test/orb/resources/plans_test.rb b/test/orb/resources/plans_test.rb
@@ -98,6 +98,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::Plan
     end
diff --git a/test/orb/resources/prices_test.rb b/test/orb/resources/prices_test.rb
@@ -1567,6 +1567,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::Price
     end
diff --git a/test/orb/resources/subscriptions_test.rb b/test/orb/resources/subscriptions_test.rb
@@ -87,6 +87,8 @@ def test_list
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::Subscription
     end
@@ -220,6 +222,8 @@ def test_fetch_schedule
     end
 
     row = response.to_enum.first
+    return if row.nil?
+
     assert_pattern do
       row => Orb::Models::SubscriptionFetchScheduleResponse
     end
