chore: fix misc linting / minor issues

Author: stainless-app[bot]

.rubocop.yml

@@ -8,7 +8,7 @@ AllCops:
     - "bin/*"
   NewCops: enable
   SuggestExtensions: false
-  TargetRubyVersion: 3.1.0
+  TargetRubyVersion: 3.2.0
 
 # Whether MFA is required or not should be left to the token configuration.
 Gemspec/RequireMFA:
@@ -112,6 +112,8 @@ Metrics/AbcSize:
 Metrics/BlockLength:
   AllowedPatterns:
     - assert_pattern
+    - type_alias
+    - define_sorbet_constant!
   Exclude:
     - "**/*.rbi"
 
@@ -182,6 +184,9 @@ Style/ClassAndModuleChildren:
   Exclude:
     - "test/**/*"
 
+Style/CommentAnnotation:
+  Enabled: false
+
 # We should go back and add these docs, but ignore for now.
 Style/Documentation:
   Enabled: false

Rakefile

@@ -41,7 +41,7 @@ desc("Lint `*.rb(i)`")
 multitask(:"lint:rubocop") do
   find = %w[find ./lib ./test ./rbi -type f -and ( -name *.rb -or -name *.rbi ) -print0]
 
-  rubocop = %w[rubocop --fail-level E]
+  rubocop = %w[rubocop]
   rubocop += %w[--format github] if ENV.key?("CI")
 
   # some lines cannot be shortened

lib/orb.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 # Standard libraries.
+# rubocop:disable Lint/RedundantRequireStatement
 require "English"
 require "cgi"
 require "date"
@@ -15,6 +16,7 @@
 require "stringio"
 require "time"
 require "uri"
+# rubocop:enable Lint/RedundantRequireStatement
 
 # We already ship the preferred sorbet manifests in the package itself.
 # `tapioca` currently does not offer us a way to opt out of unnecessary compilation.

lib/orb/errors.rb

@@ -99,7 +99,7 @@ class APIStatusError < Orb::Errors::APIError
       # @param response [nil]
       # @param message [String, nil]
       #
-      # @return [Orb::Errors::APIStatusError]
+      # @return [self]
       def self.for(url:, status:, body:, request:, response:, message: nil)
         key = Orb::Internal::Util.dig(body, :type)
         kwargs = {

rbi/orb/errors.rbi

@@ -104,7 +104,7 @@ module Orb
           request: NilClass,
           response: NilClass,
           message: T.nilable(String)
-        ).returns(T.self_type)
+        ).returns(T.attached_class)
       end
       def self.for(url:, status:, body:, request:, response:, message: nil)
       end

sig/orb/internal/type/array_of.rbs

@@ -9,7 +9,7 @@ module Orb
           | ^-> Orb::Internal::Type::Converter::input
           | Orb::Internal::Type::Converter::input type_info,
           ?::Hash[Symbol, top] spec
-        ) -> self
+        ) -> instance
 
         def ===: (top other) -> bool
 

sig/orb/internal/type/base_model.rbs

@@ -61,10 +61,10 @@ module Orb
         def self.coerce: (
           Orb::Internal::Type::BaseModel | ::Hash[top, top] | top value,
           state: Orb::Internal::Type::Converter::coerce_state
-        ) -> (self | top)
+        ) -> (instance | top)
 
         def self.dump: (
-          self | top value,
+          instance | top value,
           state: Orb::Internal::Type::Converter::dump_state
         ) -> (::Hash[top, top] | top)
 
@@ -84,7 +84,7 @@ module Orb
 
         def to_yaml: (*top a) -> String
 
-        def initialize: (?::Hash[Symbol, top] | self data) -> void
+        def initialize: (?::Hash[Symbol, top] | instance data) -> void
 
         def self.inspect: (?depth: Integer) -> String
 

sig/orb/internal/type/base_page.rbs

@@ -4,7 +4,7 @@ module Orb
       module BasePage[Elem]
         def next_page?: -> bool
 
-        def next_page: -> self
+        def next_page: -> instance
 
         def auto_paging_each: { (Elem arg0) -> void } -> void
 

sig/orb/internal/type/hash_of.rbs

@@ -9,7 +9,7 @@ module Orb
           | ^-> Orb::Internal::Type::Converter::input
           | Orb::Internal::Type::Converter::input type_info,
           ?::Hash[Symbol, top] spec
-        ) -> self
+        ) -> instance
 
         def ===: (top other) -> bool