chore: make client tests look prettier (#241)

Author: stainless-app[bot]

test/orb/client_test.rb

@@ -148,7 +148,10 @@ def test_retry_count_header
       orb.customers.create(email: "dev@stainless.com", name: "x")
     end
 
-    retry_count_headers = requester.attempts.map { _1[:headers]["x-stainless-retry-count"] }
+    retry_count_headers = requester.attempts.map do
+      _1.fetch(:headers).fetch("x-stainless-retry-count")
+    end
+
     assert_equal(%w[0 1 2], retry_count_headers)
   end
 
@@ -165,7 +168,10 @@ def test_omit_retry_count_header
       )
     end
 
-    retry_count_headers = requester.attempts.map { _1[:headers]["x-stainless-retry-count"] }
+    retry_count_headers = requester.attempts.map do
+      _1.fetch(:headers).fetch("x-stainless-retry-count", nil)
+    end
+
     assert_equal([nil, nil, nil], retry_count_headers)
   end
 
@@ -182,7 +188,10 @@ def test_overwrite_retry_count_header
       )
     end
 
-    retry_count_headers = requester.attempts.map { _1[:headers]["x-stainless-retry-count"] }
+    retry_count_headers = requester.attempts.map do
+      _1.fetch(:headers).fetch("x-stainless-retry-count")
+    end
+
     assert_equal(%w[42 42 42], retry_count_headers)
   end
 
@@ -195,12 +204,12 @@ def test_client_redirect_307
       orb.customers.create(email: "dev@stainless.com", name: "x", request_options: {extra_headers: {}})
     end
 
-    assert_equal("/redirected", requester.attempts.last[:url].path)
-    assert_equal(requester.attempts.first[:method], requester.attempts.last[:method])
-    assert_equal(requester.attempts.first[:body], requester.attempts.last[:body])
+    assert_equal("/redirected", requester.attempts.last.fetch(:url).path)
+    assert_equal(requester.attempts.first.fetch(:method), requester.attempts.last.fetch(:method))
+    assert_equal(requester.attempts.first.fetch(:body), requester.attempts.last.fetch(:body))
     assert_equal(
-      requester.attempts.first[:headers]["content-type"],
-      requester.attempts.last[:headers]["content-type"]
+      requester.attempts.first.fetch(:headers)["content-type"],
+      requester.attempts.last.fetch(:headers)["content-type"]
     )
   end
 
@@ -213,10 +222,10 @@ def test_client_redirect_303
       orb.customers.create(email: "dev@stainless.com", name: "x", request_options: {extra_headers: {}})
     end
 
-    assert_equal("/redirected", requester.attempts.last[:url].path)
-    assert_equal(:get, requester.attempts.last[:method])
-    assert_nil(requester.attempts.last[:body])
-    assert_nil(requester.attempts.last[:headers]["Content-Type"])
+    assert_equal("/redirected", requester.attempts.last.fetch(:url).path)
+    assert_equal(:get, requester.attempts.last.fetch(:method))
+    assert_nil(requester.attempts.last.fetch(:body))
+    assert_nil(requester.attempts.last.fetch(:headers)["content-type"])
   end
 
   def test_client_redirect_auth_keep_same_origin
@@ -228,13 +237,13 @@ def test_client_redirect_auth_keep_same_origin
       orb.customers.create(
         email: "dev@stainless.com",
         name: "x",
-        request_options: {extra_headers: {"Authorization" => "Bearer xyz"}}
+        request_options: {extra_headers: {"authorization" => "Bearer xyz"}}
       )
     end
 
     assert_equal(
-      requester.attempts.first[:headers]["authorization"],
-      requester.attempts.last[:headers]["authorization"]
+      requester.attempts.first.fetch(:headers)["authorization"],
+      requester.attempts.last.fetch(:headers)["authorization"]
     )
   end
 
@@ -247,11 +256,11 @@ def test_client_redirect_auth_strip_cross_origin
       orb.customers.create(
         email: "dev@stainless.com",
         name: "x",
-        request_options: {extra_headers: {"Authorization" => "Bearer xyz"}}
+        request_options: {extra_headers: {"authorization" => "Bearer xyz"}}
       )
     end
 
-    assert_nil(requester.attempts.last[:headers]["Authorization"])
+    assert_nil(requester.attempts.last.fetch(:headers)["authorization"])
   end
 
   def test_client_default_idempotency_key_on_writes
@@ -263,7 +272,9 @@ def test_client_default_idempotency_key_on_writes
       orb.customers.create(email: "dev@stainless.com", name: "x", request_options: {max_retries: 1})
     end
 
-    idempotency_headers = requester.attempts.map { _1[:headers]["Idempotency-Key".downcase] }
+    idempotency_headers = requester.attempts.map do
+      _1.fetch(:headers).fetch("idempotency-key")
+    end
 
     assert_kind_of(String, idempotency_headers.first)
     refute_empty(idempotency_headers.first)
@@ -283,15 +294,17 @@ def test_request_option_idempotency_key_on_writes
       )
     end
 
-    requester.attempts.each { assert_equal("user-supplied-key", _1[:headers]["Idempotency-Key".downcase]) }
+    requester.attempts.each do
+      assert_equal("user-supplied-key", _1.fetch(:headers).fetch("idempotency-key"))
+    end
   end
 
   def test_default_headers
     orb = Orb::Client.new(base_url: "http://localhost:4010", api_key: "My API Key")
     requester = MockRequester.new(200, {}, {})
     orb.requester = requester
     orb.customers.create(email: "dev@stainless.com", name: "x")
-    headers = requester.attempts.first[:headers]
+    headers = requester.attempts.first.fetch(:headers)
 
     refute_empty(headers["accept"])
     refute_empty(headers["content-type"])