fix(api): naming for sync_payment_methods methods (#612)

fix naming for sync_payment_methods methods (by customer_id and by external_customer_id were swapped)

Author: stainless-app[bot]

.stats.yml

@@ -1,4 +1,4 @@
 configured_endpoints: 103
 openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/orb%2Forb-95a3d7780935a38e0cf076d4ad2d68bd1a5641bced8398d972db2e92751d364a.yml
 openapi_spec_hash: 9ebe818c4ad4f2d9c4e473b5192d7544
-config_hash: 3dc5bc1df028fc7301fb2ada9846f038
+config_hash: 54edf41f0377bc235f622fdaa7405f22

api.md

@@ -76,8 +76,8 @@ Methods:
 - <code title="delete /customers/{customer_id}">client.customers.<a href="./src/orb/resources/customers/customers.py">delete</a>(customer_id) -> None</code>
 - <code title="get /customers/{customer_id}">client.customers.<a href="./src/orb/resources/customers/customers.py">fetch</a>(customer_id) -> <a href="./src/orb/types/customer.py">Customer</a></code>
 - <code title="get /customers/external_customer_id/{external_customer_id}">client.customers.<a href="./src/orb/resources/customers/customers.py">fetch_by_external_id</a>(external_customer_id) -> <a href="./src/orb/types/customer.py">Customer</a></code>
-- <code title="post /customers/external_customer_id/{external_customer_id}/sync_payment_methods_from_gateway">client.customers.<a href="./src/orb/resources/customers/customers.py">sync_payment_methods_from_gateway</a>(external_customer_id) -> None</code>
-- <code title="post /customers/{customer_id}/sync_payment_methods_from_gateway">client.customers.<a href="./src/orb/resources/customers/customers.py">sync_payment_methods_from_gateway_by_external_customer_id</a>(customer_id) -> None</code>
+- <code title="post /customers/{customer_id}/sync_payment_methods_from_gateway">client.customers.<a href="./src/orb/resources/customers/customers.py">sync_payment_methods_from_gateway</a>(customer_id) -> None</code>
+- <code title="post /customers/external_customer_id/{external_customer_id}/sync_payment_methods_from_gateway">client.customers.<a href="./src/orb/resources/customers/customers.py">sync_payment_methods_from_gateway_by_external_customer_id</a>(external_customer_id) -> None</code>
 - <code title="put /customers/external_customer_id/{external_customer_id}">client.customers.<a href="./src/orb/resources/customers/customers.py">update_by_external_id</a>(id, \*\*<a href="src/orb/types/customer_update_by_external_id_params.py">params</a>) -> <a href="./src/orb/types/customer.py">Customer</a></code>
 
 ## Costs

src/orb/resources/customers/customers.py

@@ -742,7 +742,7 @@ def fetch_by_external_id(
 
     def sync_payment_methods_from_gateway(
         self,
-        external_customer_id: str,
+        customer_id: str,
         *,
         # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
         # The extra values given here take precedence over values defined on the client or passed to this method.
@@ -771,13 +771,11 @@ def sync_payment_methods_from_gateway(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
-        if not external_customer_id:
-            raise ValueError(
-                f"Expected a non-empty value for `external_customer_id` but received {external_customer_id!r}"
-            )
+        if not customer_id:
+            raise ValueError(f"Expected a non-empty value for `customer_id` but received {customer_id!r}")
         extra_headers = {"Accept": "*/*", **(extra_headers or {})}
         return self._post(
-            f"/customers/external_customer_id/{external_customer_id}/sync_payment_methods_from_gateway",
+            f"/customers/{customer_id}/sync_payment_methods_from_gateway",
             options=make_request_options(
                 extra_headers=extra_headers,
                 extra_query=extra_query,
@@ -790,7 +788,7 @@ def sync_payment_methods_from_gateway(
 
     def sync_payment_methods_from_gateway_by_external_customer_id(
         self,
-        customer_id: str,
+        external_customer_id: str,
         *,
         # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
         # The extra values given here take precedence over values defined on the client or passed to this method.
@@ -819,11 +817,13 @@ def sync_payment_methods_from_gateway_by_external_customer_id(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
-        if not customer_id:
-            raise ValueError(f"Expected a non-empty value for `customer_id` but received {customer_id!r}")
+        if not external_customer_id:
+            raise ValueError(
+                f"Expected a non-empty value for `external_customer_id` but received {external_customer_id!r}"
+            )
         extra_headers = {"Accept": "*/*", **(extra_headers or {})}
         return self._post(
-            f"/customers/{customer_id}/sync_payment_methods_from_gateway",
+            f"/customers/external_customer_id/{external_customer_id}/sync_payment_methods_from_gateway",
             options=make_request_options(
                 extra_headers=extra_headers,
                 extra_query=extra_query,
@@ -1748,7 +1748,7 @@ async def fetch_by_external_id(
 
     async def sync_payment_methods_from_gateway(
         self,
-        external_customer_id: str,
+        customer_id: str,
         *,
         # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
         # The extra values given here take precedence over values defined on the client or passed to this method.
@@ -1777,13 +1777,11 @@ async def sync_payment_methods_from_gateway(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
-        if not external_customer_id:
-            raise ValueError(
-                f"Expected a non-empty value for `external_customer_id` but received {external_customer_id!r}"
-            )
+        if not customer_id:
+            raise ValueError(f"Expected a non-empty value for `customer_id` but received {customer_id!r}")
         extra_headers = {"Accept": "*/*", **(extra_headers or {})}
         return await self._post(
-            f"/customers/external_customer_id/{external_customer_id}/sync_payment_methods_from_gateway",
+            f"/customers/{customer_id}/sync_payment_methods_from_gateway",
             options=make_request_options(
                 extra_headers=extra_headers,
                 extra_query=extra_query,
@@ -1796,7 +1794,7 @@ async def sync_payment_methods_from_gateway(
 
     async def sync_payment_methods_from_gateway_by_external_customer_id(
         self,
-        customer_id: str,
+        external_customer_id: str,
         *,
         # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
         # The extra values given here take precedence over values defined on the client or passed to this method.
@@ -1825,11 +1823,13 @@ async def sync_payment_methods_from_gateway_by_external_customer_id(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
-        if not customer_id:
-            raise ValueError(f"Expected a non-empty value for `customer_id` but received {customer_id!r}")
+        if not external_customer_id:
+            raise ValueError(
+                f"Expected a non-empty value for `external_customer_id` but received {external_customer_id!r}"
+            )
         extra_headers = {"Accept": "*/*", **(extra_headers or {})}
         return await self._post(
-            f"/customers/{customer_id}/sync_payment_methods_from_gateway",
+            f"/customers/external_customer_id/{external_customer_id}/sync_payment_methods_from_gateway",
             options=make_request_options(
                 extra_headers=extra_headers,
                 extra_query=extra_query,

tests/api_resources/test_customers.py

@@ -361,14 +361,14 @@ def test_path_params_fetch_by_external_id(self, client: Orb) -> None:
     @parametrize
     def test_method_sync_payment_methods_from_gateway(self, client: Orb) -> None:
         customer = client.customers.sync_payment_methods_from_gateway(
-            "external_customer_id",
+            "customer_id",
         )
         assert customer is None
 
     @parametrize
     def test_raw_response_sync_payment_methods_from_gateway(self, client: Orb) -> None:
         response = client.customers.with_raw_response.sync_payment_methods_from_gateway(
-            "external_customer_id",
+            "customer_id",
         )
 
         assert response.is_closed is True
@@ -379,7 +379,7 @@ def test_raw_response_sync_payment_methods_from_gateway(self, client: Orb) -> No
     @parametrize
     def test_streaming_response_sync_payment_methods_from_gateway(self, client: Orb) -> None:
         with client.customers.with_streaming_response.sync_payment_methods_from_gateway(
-            "external_customer_id",
+            "customer_id",
         ) as response:
             assert not response.is_closed
             assert response.http_request.headers.get("X-Stainless-Lang") == "python"
@@ -391,22 +391,22 @@ def test_streaming_response_sync_payment_methods_from_gateway(self, client: Orb)
 
     @parametrize
     def test_path_params_sync_payment_methods_from_gateway(self, client: Orb) -> None:
-        with pytest.raises(ValueError, match=r"Expected a non-empty value for `external_customer_id` but received ''"):
+        with pytest.raises(ValueError, match=r"Expected a non-empty value for `customer_id` but received ''"):
             client.customers.with_raw_response.sync_payment_methods_from_gateway(
                 "",
             )
 
     @parametrize
     def test_method_sync_payment_methods_from_gateway_by_external_customer_id(self, client: Orb) -> None:
         customer = client.customers.sync_payment_methods_from_gateway_by_external_customer_id(
-            "customer_id",
+            "external_customer_id",
         )
         assert customer is None
 
     @parametrize
     def test_raw_response_sync_payment_methods_from_gateway_by_external_customer_id(self, client: Orb) -> None:
         response = client.customers.with_raw_response.sync_payment_methods_from_gateway_by_external_customer_id(
-            "customer_id",
+            "external_customer_id",
         )
 
         assert response.is_closed is True
@@ -417,7 +417,7 @@ def test_raw_response_sync_payment_methods_from_gateway_by_external_customer_id(
     @parametrize
     def test_streaming_response_sync_payment_methods_from_gateway_by_external_customer_id(self, client: Orb) -> None:
         with client.customers.with_streaming_response.sync_payment_methods_from_gateway_by_external_customer_id(
-            "customer_id",
+            "external_customer_id",
         ) as response:
             assert not response.is_closed
             assert response.http_request.headers.get("X-Stainless-Lang") == "python"
@@ -429,7 +429,7 @@ def test_streaming_response_sync_payment_methods_from_gateway_by_external_custom
 
     @parametrize
     def test_path_params_sync_payment_methods_from_gateway_by_external_customer_id(self, client: Orb) -> None:
-        with pytest.raises(ValueError, match=r"Expected a non-empty value for `customer_id` but received ''"):
+        with pytest.raises(ValueError, match=r"Expected a non-empty value for `external_customer_id` but received ''"):
             client.customers.with_raw_response.sync_payment_methods_from_gateway_by_external_customer_id(
                 "",
             )
@@ -873,14 +873,14 @@ async def test_path_params_fetch_by_external_id(self, async_client: AsyncOrb) ->
     @parametrize
     async def test_method_sync_payment_methods_from_gateway(self, async_client: AsyncOrb) -> None:
         customer = await async_client.customers.sync_payment_methods_from_gateway(
-            "external_customer_id",
+            "customer_id",
         )
         assert customer is None
 
     @parametrize
     async def test_raw_response_sync_payment_methods_from_gateway(self, async_client: AsyncOrb) -> None:
         response = await async_client.customers.with_raw_response.sync_payment_methods_from_gateway(
-            "external_customer_id",
+            "customer_id",
         )
 
         assert response.is_closed is True
@@ -891,7 +891,7 @@ async def test_raw_response_sync_payment_methods_from_gateway(self, async_client
     @parametrize
     async def test_streaming_response_sync_payment_methods_from_gateway(self, async_client: AsyncOrb) -> None:
         async with async_client.customers.with_streaming_response.sync_payment_methods_from_gateway(
-            "external_customer_id",
+            "customer_id",
         ) as response:
             assert not response.is_closed
             assert response.http_request.headers.get("X-Stainless-Lang") == "python"
@@ -903,7 +903,7 @@ async def test_streaming_response_sync_payment_methods_from_gateway(self, async_
 
     @parametrize
     async def test_path_params_sync_payment_methods_from_gateway(self, async_client: AsyncOrb) -> None:
-        with pytest.raises(ValueError, match=r"Expected a non-empty value for `external_customer_id` but received ''"):
+        with pytest.raises(ValueError, match=r"Expected a non-empty value for `customer_id` but received ''"):
             await async_client.customers.with_raw_response.sync_payment_methods_from_gateway(
                 "",
             )
@@ -913,7 +913,7 @@ async def test_method_sync_payment_methods_from_gateway_by_external_customer_id(
         self, async_client: AsyncOrb
     ) -> None:
         customer = await async_client.customers.sync_payment_methods_from_gateway_by_external_customer_id(
-            "customer_id",
+            "external_customer_id",
         )
         assert customer is None
 
@@ -923,7 +923,7 @@ async def test_raw_response_sync_payment_methods_from_gateway_by_external_custom
     ) -> None:
         response = (
             await async_client.customers.with_raw_response.sync_payment_methods_from_gateway_by_external_customer_id(
-                "customer_id",
+                "external_customer_id",
             )
         )
 
@@ -938,7 +938,7 @@ async def test_streaming_response_sync_payment_methods_from_gateway_by_external_
     ) -> None:
         async with (
             async_client.customers.with_streaming_response.sync_payment_methods_from_gateway_by_external_customer_id(
-                "customer_id",
+                "external_customer_id",
             )
         ) as response:
             assert not response.is_closed
@@ -953,7 +953,7 @@ async def test_streaming_response_sync_payment_methods_from_gateway_by_external_
     async def test_path_params_sync_payment_methods_from_gateway_by_external_customer_id(
         self, async_client: AsyncOrb
     ) -> None:
-        with pytest.raises(ValueError, match=r"Expected a non-empty value for `customer_id` but received ''"):
+        with pytest.raises(ValueError, match=r"Expected a non-empty value for `external_customer_id` but received ''"):
             await async_client.customers.with_raw_response.sync_payment_methods_from_gateway_by_external_customer_id(
                 "",
             )