chore(api): correctly support ExternalCustomerID array filter on Subscriptions.List (#340)

Author: stainless-app[bot]

.stats.yml

@@ -1,2 +1,2 @@
 configured_endpoints: 103
-openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/orb%2Forb-979330185e8fda7b2bc2440075fe81c66132fc87ff3c548e93dd05db35ba3172.yml
+openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/orb%2Forb-e3aeba4569f0d304b27804cc2cdd9888f3f58628fe426e206ab49e164e5417bd.yml

orb-java-core/src/main/kotlin/com/withorb/api/models/SubscriptionListParams.kt

@@ -35,7 +35,7 @@ private constructor(
     private val createdAtLte: OffsetDateTime?,
     private val cursor: String?,
     private val customerId: List<String>?,
-    private val externalCustomerId: String?,
+    private val externalCustomerId: List<String>?,
     private val limit: Long?,
     private val status: Status?,
     private val additionalHeaders: Headers,
@@ -58,7 +58,7 @@ private constructor(
 
     fun customerId(): Optional<List<String>> = Optional.ofNullable(customerId)
 
-    fun externalCustomerId(): Optional<String> = Optional.ofNullable(externalCustomerId)
+    fun externalCustomerId(): Optional<List<String>> = Optional.ofNullable(externalCustomerId)
 
     /** The number of items to fetch. Defaults to 20. */
     fun limit(): Optional<Long> = Optional.ofNullable(limit)
@@ -100,7 +100,7 @@ private constructor(
         this.cursor?.let { queryParams.put("cursor", listOf(it.toString())) }
         this.customerId?.let { queryParams.put("customer_id[]", it.map(Any::toString)) }
         this.externalCustomerId?.let {
-            queryParams.put("external_customer_id", listOf(it.toString()))
+            queryParams.put("external_customer_id[]", it.map(Any::toString))
         }
         this.limit?.let { queryParams.put("limit", listOf(it.toString())) }
         this.status?.let { queryParams.put("status", listOf(it.toString())) }
@@ -128,7 +128,7 @@ private constructor(
         private var createdAtLte: OffsetDateTime? = null
         private var cursor: String? = null
         private var customerId: MutableList<String>? = null
-        private var externalCustomerId: String? = null
+        private var externalCustomerId: MutableList<String>? = null
         private var limit: Long? = null
         private var status: Status? = null
         private var additionalHeaders: Headers.Builder = Headers.builder()
@@ -142,7 +142,7 @@ private constructor(
             createdAtLte = subscriptionListParams.createdAtLte
             cursor = subscriptionListParams.cursor
             customerId = subscriptionListParams.customerId?.toMutableList()
-            externalCustomerId = subscriptionListParams.externalCustomerId
+            externalCustomerId = subscriptionListParams.externalCustomerId?.toMutableList()
             limit = subscriptionListParams.limit
             status = subscriptionListParams.status
             additionalHeaders = subscriptionListParams.additionalHeaders.toBuilder()
@@ -191,13 +191,18 @@ private constructor(
             this.customerId = (this.customerId ?: mutableListOf()).apply { add(customerId) }
         }
 
-        fun externalCustomerId(externalCustomerId: String?) = apply {
-            this.externalCustomerId = externalCustomerId
+        fun externalCustomerId(externalCustomerId: List<String>?) = apply {
+            this.externalCustomerId = externalCustomerId?.toMutableList()
         }
 
-        fun externalCustomerId(externalCustomerId: Optional<String>) =
+        fun externalCustomerId(externalCustomerId: Optional<List<String>>) =
             externalCustomerId(externalCustomerId.getOrNull())
 
+        fun addExternalCustomerId(externalCustomerId: String) = apply {
+            this.externalCustomerId =
+                (this.externalCustomerId ?: mutableListOf()).apply { add(externalCustomerId) }
+        }
+
         /** The number of items to fetch. Defaults to 20. */
         fun limit(limit: Long?) = apply { this.limit = limit }
 
@@ -317,7 +322,7 @@ private constructor(
                 createdAtLte,
                 cursor,
                 customerId?.toImmutable(),
-                externalCustomerId,
+                externalCustomerId?.toImmutable(),
                 limit,
                 status,
                 additionalHeaders.build(),

orb-java-core/src/test/kotlin/com/withorb/api/models/SubscriptionListParamsTest.kt

@@ -18,7 +18,7 @@ class SubscriptionListParamsTest {
             .createdAtLte(OffsetDateTime.parse("2019-12-27T18:11:19.117Z"))
             .cursor("cursor")
             .addCustomerId("string")
-            .externalCustomerId("external_customer_id")
+            .addExternalCustomerId("string")
             .limit(1L)
             .status(SubscriptionListParams.Status.ACTIVE)
             .build()
@@ -34,7 +34,7 @@ class SubscriptionListParamsTest {
                 .createdAtLte(OffsetDateTime.parse("2019-12-27T18:11:19.117Z"))
                 .cursor("cursor")
                 .addCustomerId("string")
-                .externalCustomerId("external_customer_id")
+                .addExternalCustomerId("string")
                 .limit(1L)
                 .status(SubscriptionListParams.Status.ACTIVE)
                 .build()
@@ -45,7 +45,7 @@ class SubscriptionListParamsTest {
         expected.put("created_at[lte]", "2019-12-27T18:11:19.117Z")
         expected.put("cursor", "cursor")
         expected.put("customer_id[]", "string")
-        expected.put("external_customer_id", "external_customer_id")
+        expected.put("external_customer_id[]", "string")
         expected.put("limit", "1")
         expected.put("status", SubscriptionListParams.Status.ACTIVE.toString())
         assertThat(params._queryParams()).isEqualTo(expected.build())