feat(client): support .NET Standard 2.0

Author: stainless-app[bot]

.editorconfig

@@ -24,3 +24,8 @@ insert_final_newline = true
 dotnet_diagnostic.IDE0060.severity = none # Caused by resource with no methods and no subresources
 dotnet_diagnostic.IDE1006.severity = none # Some names may not match up with C# conventions
 dotnet_diagnostic.IDE0290.severity = none # Don't prefer primary constructors
+
+# For .NET Standard 2.0 support
+dotnet_diagnostic.IDE0057.severity = none # Caused by use of `.Substring(...)`
+dotnet_diagnostic.CA1866.severity = none # Caused by use of `.StartsWith(...)` with single character string
+dotnet_diagnostic.CA1847.severity = none # Caused by use of `.Contains(...)` with single character string

.github/workflows/ci.yml

@@ -58,7 +58,7 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Set up .NET
-        uses: actions/setup-dotnet@v3
+        uses: actions/setup-dotnet@v5
         with:
           dotnet-version: '8.0.x'
 

README.md

@@ -20,10 +20,7 @@ dotnet add reference orb-csharp/src/Orb
 
 ## Requirements
 
-This library requires .NET 8 or later.
-
-> [!NOTE]
-> The library is currently in **beta**. The requirements will be lowered in the future.
+This library requires .NET Standard 2.0 or later.
 
 ## Usage
 

src/Orb.Tests/Orb.Tests.csproj

@@ -1,7 +1,10 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <!-- Run tests on net8.0, which will use the SDK's net8.0 DLL, and on net462, which will use the
+    SDK's netstandard2.0 DLL. -->
+    <TargetFrameworks>net8.0;net462</TargetFrameworks>
+    <LangVersion>latest</LangVersion>
 
     <Nullable>enable</Nullable>
 

src/Orb.Tests/Services/CreditNoteServiceTest.cs

@@ -18,8 +18,20 @@ public async Task Create_Works()
                     {
                         Amount = "amount",
                         InvoiceLineItemID = "4khy3nwzktxv7",
-                        EndDate = DateOnly.Parse("2023-09-22"),
-                        StartDate = DateOnly.Parse("2023-09-22"),
+                        EndDate =
+#if NET
+                        DateOnly
+#else
+                        DateTimeOffset
+#endif
+                        .Parse("2023-09-22"),
+                        StartDate =
+#if NET
+                        DateOnly
+#else
+                        DateTimeOffset
+#endif
+                        .Parse("2023-09-22"),
                     },
                 ],
                 Reason = Reason.Duplicate,

src/Orb.Tests/Services/Customers/Credits/LedgerServiceTest.cs

@@ -40,8 +40,20 @@ public async Task CreateEntry_Works()
                     InvoiceSettings = new()
                     {
                         AutoCollection = true,
-                        CustomDueDate = DateOnly.Parse("2019-12-27"),
-                        InvoiceDate = DateOnly.Parse("2019-12-27"),
+                        CustomDueDate =
+#if NET
+                        DateOnly
+#else
+                        DateTimeOffset
+#endif
+                        .Parse("2019-12-27"),
+                        InvoiceDate =
+#if NET
+                        DateOnly
+#else
+                        DateTimeOffset
+#endif
+                        .Parse("2019-12-27"),
                         ItemID = "item_id",
                         Memo = "memo",
                         NetTerms = 0,
@@ -81,8 +93,20 @@ public async Task CreateEntryByExternalID_Works()
                     InvoiceSettings = new()
                     {
                         AutoCollection = true,
-                        CustomDueDate = DateOnly.Parse("2019-12-27"),
-                        InvoiceDate = DateOnly.Parse("2019-12-27"),
+                        CustomDueDate =
+#if NET
+                        DateOnly
+#else
+                        DateTimeOffset
+#endif
+                        .Parse("2019-12-27"),
+                        InvoiceDate =
+#if NET
+                        DateOnly
+#else
+                        DateTimeOffset
+#endif
+                        .Parse("2019-12-27"),
                         ItemID = "item_id",
                         Memo = "memo",
                         NetTerms = 0,

src/Orb.Tests/Services/InvoiceLineItemServiceTest.cs

@@ -12,10 +12,22 @@ public async Task Create_Works()
             new()
             {
                 Amount = "12.00",
-                EndDate = DateOnly.Parse("2023-09-22"),
+                EndDate =
+#if NET
+                DateOnly
+#else
+                DateTimeOffset
+#endif
+                .Parse("2023-09-22"),
                 InvoiceID = "4khy3nwzktxv7",
                 Quantity = 1,
-                StartDate = DateOnly.Parse("2023-09-22"),
+                StartDate =
+#if NET
+                DateOnly
+#else
+                DateTimeOffset
+#endif
+                .Parse("2023-09-22"),
             }
         );
         invoiceLineItem.Validate();

src/Orb.Tests/Services/InvoiceServiceTest.cs

@@ -18,12 +18,24 @@ public async Task Create_Works()
                 [
                     new()
                     {
-                        EndDate = DateOnly.Parse("2023-09-22"),
+                        EndDate =
+#if NET
+                        DateOnly
+#else
+                        DateTimeOffset
+#endif
+                        .Parse("2023-09-22"),
                         ItemID = "4khy3nwzktxv7",
                         ModelType = ModelType.Unit,
                         Name = "Line Item Name",
                         Quantity = 1,
-                        StartDate = DateOnly.Parse("2023-09-22"),
+                        StartDate =
+#if NET
+                        DateOnly
+#else
+                        DateTimeOffset
+#endif
+                        .Parse("2023-09-22"),
                         UnitConfig = new() { UnitAmount = "unit_amount", Prorated = true },
                     },
                 ],
@@ -74,7 +86,13 @@ public async Task MarkPaid_Works()
     {
         var invoice = await this.client.Invoices.MarkPaid(
             "invoice_id",
-            new() { PaymentReceivedDate = DateOnly.Parse("2023-09-22") }
+            new() { PaymentReceivedDate =
+#if NET
+                DateOnly
+#else
+                DateTimeOffset
+#endif
+                .Parse("2023-09-22") }
         );
         invoice.Validate();
     }

src/Orb/Core/ApiEnum.cs

@@ -19,7 +19,7 @@ public readonly TEnum Value() =>
 
     public readonly void Validate()
     {
-        if (!Enum.IsDefined(Value()))
+        if (!Enum.IsDefined(typeof(TEnum), Value()))
         {
             throw new OrbInvalidDataException("Invalid enum value");
         }

src/Orb/Core/FreezableDictionary.cs

@@ -2,6 +2,7 @@
 using System.Collections.Frozen;
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
+using System.Linq;
 using Collections = System.Collections;
 
 namespace Orb.Core;
@@ -34,7 +35,7 @@ public FreezableDictionary() { }
 
     public FreezableDictionary(IReadOnlyDictionary<K, V> dictionary)
     {
-        _dictionary = new Dictionary<K, V>(dictionary);
+        _dictionary = Enumerable.ToDictionary(dictionary, e => e.Key, e => e.Value);
     }
 
     public FreezableDictionary(FrozenDictionary<K, V> frozen)
@@ -126,7 +127,12 @@ public bool Remove(KeyValuePair<K, V> item)
         return _mutableDictionary.Remove(item.Key);
     }
 
-    public bool TryGetValue(K key, [MaybeNullWhenAttribute(false)] out V value)
+    public bool TryGetValue(K key,
+#if NET
+        [MaybeNullWhen(false)]
+#endif
+
+        out V value)
     {
         return _dictionary.TryGetValue(key, out value);
     }