lint rule: "a message should only be used once"

[samuelstroschein]

Problem

Referencing the same message in multiple places leads to a broken message.

No guarantee exists that a message with the content like "learn more" won't be changed by someone to "learn more about unlimited inboxes". If the message is rendering all "learn more" references, the example website below will break at 2 and 3.

Proposal

A lint rule that detects if a message id is used multiple times in source code.

// unlimited inboxes
<p>{m.elephant_big_tree()}</p>

// manage team members
// 💥 error m.elephant is used multiple times
<p>{m.elephant_big_tree()}</p>

// spam report
// 💥 error m.elephant is used multiple times
<p>{m.blue_box({ title: m.elephant_big_tree() })}</p>

(Creating new messages is cheaper nowadays with AI translations than trying to manage shared messages.)

Additional information

• emerged in a conversation on discord https://discord.com/channels/897438559458430986/1206732202839253052/1208848809304530974
• requires https://github.com/opral/monorepo/discussions/2126

[linear]

MESDK-42 lint rule: "a message should only be used once"

[shivan-s]

https://github.com/opral/monorepo/discussions/2253 is 404'ing. Don't know if that's important but might give good context.

[shivan-s]

Hey @samuelstroschein, if it's not too much trouble, are you able to explain the perf concern of reusing messages?

My thoughts are that if the messages are turned into functions, they can be used anywhere without a significant performance cost.

Could a team have a policy to not change messages or check what impact a message change has?

[samuelstroschein]

Which performance concern?

[shivan-s]

(Creating new messages is cheaper than trying to manage shared messages.)

Maybe I misinterpreted this as a performance.

[samuelstroschein]

I changed the phrasing 👍

[shivan-s]

Ahh, thank you.