-
Notifications
You must be signed in to change notification settings - Fork 28
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Is your feature request related to a problem? Please describe.
The native menu can currently be used even when a popup is open. This leads to weird situations, e.g. a file can be opened while the import dialog is open, and the import dialog stays open through the whole process.
Describe the solution you'd like
- Menu items that start a new workflow / open a new popup should be disabled while a popup is open
- e.g. open, import etc. should be disabled
- there may be some menu items that don't have to be disabled, such as e.g. the zoom in and zoom out menu items
- For this issue, it is sufficient to consider the popups that are handled through the GlobalPopup mechanism as well as the ProcessPopup
- For any other popups (such as the ConfirmationDialog): investigate if there are any issues with allowing menu item interaction while these popups are open. If yes, create a separate issue to implement a similar solution for these other popups.
- Implementation suggestions/considerations:
- Create an IPC channel so that the frontend can instruct the backend to disable the app menu
- When reenabling the app menu, make sure to only enable menu items which were already enabled before the popup was opened (some menu items are disabled at application startup and only get enabled when a file is opened)
- For popups handled through GlobalPopup, send IPC messages for disabling/enabling menu items when the openPopup/closePopup redux actions are created
- For the ProcessPopup, send IPC messages when there are changes in the loading state which it uses as its open condition
Describe alternatives you've considered
An alternative would be to allow the user to close open popups when they click on an item in the app menu, but the solution described above is probably easier.
Additional context
-
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working