Skip to content

Commit c18816f

Browse files
committed
cvsserver: avoid precedence problem between ! and %s
With perl-5.41.4 and newer git-cvsserver fails to build because of possilbe precedence problem[0] Added parentheses avoid this issue. Full credit for finding the issue and coming up with the fix goes to Jitka Plesnikova (jplesnik@redhat.com) [0] https://metacpan.org/release/ETHER/perl-5.41.12/view/pod/perl5414delta.pod#New-Warnings Signed-off-by: Ondřej Pohořelský <opohorel@redhat.com>
1 parent cb96e16 commit c18816f

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

git-cvsserver.perl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5009,7 +5009,7 @@ sub escapeRefName
50095009
# = "_-xx-" Where "xx" is the hexadecimal representation of the
50105010
# desired ASCII character byte. (for anything else)
50115011

5012-
if(! $refName=~/^[1-9][0-9]*(\.[1-9][0-9]*)*$/)
5012+
if(! ($refName=~/^[1-9][0-9]*(\.[1-9][0-9]*)*$/))
50135013
{
50145014
$refName=~s/_-/_-u--/g;
50155015
$refName=~s/\./_-p-/g;

0 commit comments

Comments
 (0)