From 82cf888a2abfa5264880909c7d6c86a6e5059aa1 Mon Sep 17 00:00:00 2001 From: Daniel Lysfjord Date: Wed, 4 Feb 2026 21:47:02 +0100 Subject: [PATCH 1/2] Add support for having backing up to a subdirectory instead of the root backupdir --- .../mvc/app/library/OPNsense/Backup/Nextcloud.php | 12 ++++++++++++ .../app/models/OPNsense/Backup/NextcloudSettings.xml | 4 ++++ 2 files changed, 16 insertions(+) diff --git a/sysutils/nextcloud-backup/src/opnsense/mvc/app/library/OPNsense/Backup/Nextcloud.php b/sysutils/nextcloud-backup/src/opnsense/mvc/app/library/OPNsense/Backup/Nextcloud.php index 6f72ba479e..673aefdd3f 100644 --- a/sysutils/nextcloud-backup/src/opnsense/mvc/app/library/OPNsense/Backup/Nextcloud.php +++ b/sysutils/nextcloud-backup/src/opnsense/mvc/app/library/OPNsense/Backup/Nextcloud.php @@ -84,6 +84,13 @@ public function getConfigurationFields() "type" => "text", "label" => gettext("Directory Name without leading slash, starting from user's root"), "value" => 'OPNsense-Backup' + ), + array( + "name" => "addhostname", + "type" => "checkbox", + "label" => gettext("Backup to directory named after hostname"), + "help" => gettext("Create subdirectory under backupdir for this host"), + "value" => null ) ); $nextcloud = new NextcloudSettings(); @@ -138,6 +145,11 @@ public function backup() $password = (string)$nextcloud->password; $backupdir = (string)$nextcloud->backupdir; $crypto_password = (string)$nextcloud->password_encryption; + $add_hostname = (string)$nextcloud->addhostname; + + if ($add_hostname) { + $backupdir .= "/".gethostname()."/" + } // Check if destination directory exists, create (full path) if not try { diff --git a/sysutils/nextcloud-backup/src/opnsense/mvc/app/models/OPNsense/Backup/NextcloudSettings.xml b/sysutils/nextcloud-backup/src/opnsense/mvc/app/models/OPNsense/Backup/NextcloudSettings.xml index 10a12429e9..048ae22071 100644 --- a/sysutils/nextcloud-backup/src/opnsense/mvc/app/models/OPNsense/Backup/NextcloudSettings.xml +++ b/sysutils/nextcloud-backup/src/opnsense/mvc/app/models/OPNsense/Backup/NextcloudSettings.xml @@ -49,5 +49,9 @@ OPNsense-Backup The Backup Directory can only consist of alphanumeric characters, dash, underscores and slash. No leading or trailing slash. + + 0 + Y + From 71359cd8972a46117e58c3976ed679d635d1b4d1 Mon Sep 17 00:00:00 2001 From: Daniel Lysfjord Date: Sat, 7 Feb 2026 15:00:00 +0100 Subject: [PATCH 2/2] Remember those semicolons.. --- .../src/opnsense/mvc/app/library/OPNsense/Backup/Nextcloud.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysutils/nextcloud-backup/src/opnsense/mvc/app/library/OPNsense/Backup/Nextcloud.php b/sysutils/nextcloud-backup/src/opnsense/mvc/app/library/OPNsense/Backup/Nextcloud.php index 673aefdd3f..597e999359 100644 --- a/sysutils/nextcloud-backup/src/opnsense/mvc/app/library/OPNsense/Backup/Nextcloud.php +++ b/sysutils/nextcloud-backup/src/opnsense/mvc/app/library/OPNsense/Backup/Nextcloud.php @@ -148,7 +148,7 @@ public function backup() $add_hostname = (string)$nextcloud->addhostname; if ($add_hostname) { - $backupdir .= "/".gethostname()."/" + $backupdir .= "/".gethostname()."/"; } // Check if destination directory exists, create (full path) if not