Feat/label driven yurtnode conversion#2533
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2533 +/- ##
==========================================
+ Coverage 43.95% 45.24% +1.28%
==========================================
Files 400 404 +4
Lines 26541 27413 +872
==========================================
+ Hits 11666 12402 +736
- Misses 13809 13850 +41
- Partials 1066 1161 +95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if o.ConcurrentYurtNodeConversionWorkers <= 0 { | ||
| errs = append(errs, fmt.Errorf("concurrent-yurtnodeconversion-workers(%d) is invalid, should greater than 0", o.ConcurrentYurtNodeConversionWorkers)) | ||
| } | ||
| if len(o.YurthubBinaryURL) == 0 && len(o.YurthubVersion) == 0 { |
There was a problem hiding this comment.
Can YurthubBinaryURL and YurthubVersion be configured simultaneously?
| kubeadmConfPaths: strings.Join(components.GetDefaultKubeadmConfPath(), ","), | ||
| openyurtDir: constants.OpenyurtDir, | ||
| kubeadmConfPaths: strings.Join(components.GetDefaultKubeadmConfPath(), ","), | ||
| namespace: constants.YurthubNamespace, |
There was a problem hiding this comment.
What is the purpose of a namespace?
There was a problem hiding this comment.
changed to set the default namespace for convert/revert job
| "convert", | ||
| fmt.Sprintf("--%s=%s", constants.NodeName, nodeName), | ||
| fmt.Sprintf("--%s=%s", constants.Namespace, valueOrDefault(tmplCtx["namespace"], DefaultConversionJobNamespace)), | ||
| fmt.Sprintf("--%s=%s", workingModeFlag, valueOrDefault(tmplCtx["workingMode"], defaultWorkingMode)), |
There was a problem hiding this comment.
Does it still support working mode?
There was a problem hiding this comment.
edge for default
| "k8s.io/klog/v2" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| ) | ||
|
|
There was a problem hiding this comment.
You can directly use crictl to delete the containers on the node.
| // for inspection instead of recreating the Job indefinitely | ||
| if isJobFailed(job) { | ||
| klog.Info(Format("node(%s) observed failed %s job %s", node.Name, currentJobAction, job.Name)) | ||
| if err := r.ensureNodeUnschedulable(ctx, node.Name, false); err != nil { |
There was a problem hiding this comment.
This needs to be considered: after a failure, scheduling may not still be possible.
There was a problem hiding this comment.
keep convert/revert node cordon until success
Vacant-lot07734
force-pushed
the
feat/label-driven-yurtnode-conversion
branch
5 times, most recently
from
df0fe21 to
d19f131
Compare
…r yurthub systemd deployment
…ersion and revert
…hub conversion and revert" This reverts commit 94cef5a.
… yurthub lifecycle
…ct is-edge-worker label
Vacant-lot07734
force-pushed
the
feat/label-driven-yurtnode-conversion
branch
from
cab2339 to
12d4cdb
Compare
|
Vacant-lot07734
changed the title
|
/LGTM |
2 participants
What type of PR is this?
What this PR does / why we need it:
#2530
This PR currently covers seven key parts:
node-servant convert/revertfrom the old static-pod-based path to the newsystemd + host binarypath.node-servantJob contract so that convert and revert can be driven by the controller through one unified Job model.YurtNodeConversionControllertoyurt-managerto watch Node label changes and conversion Jobs, then orchestrate convert/revert rounds.openyurt.io/is-edge-workeras a controller-managed label and only allowapps.openyurt.io/nodepoolto be added or removed, not modified in place.Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note