From eea42be2321ed483efc3b4ae0e5b2ae1ff7111cf Mon Sep 17 00:00:00 2001 From: Bhavani Subramanian Date: Fri, 3 Apr 2026 11:05:47 -0700 Subject: [PATCH] PR #40331: [XLA:GPU][oneAPI] Fix build failure in IntelGpuCompiler Imported from GitHub PR https://github.com/openxla/xla/pull/40331 https://github.com/openxla/xla/commit/00b5900c1229ec3160aff469f88d5a43724f0cc4 commit in XLA causes the following failure in oneAPI GPU CI build: ``` ./xla/service/gpu/intel_gpu_compiler.h:57:71: error: non-virtual member function marked 'override' hides virtual member function 57 | const CompileOptions& options, std::optional shard_number) override; | ^ ./xla/service/gpu/gpu_compiler.h:266:48: note: hidden overloaded virtual function 'xla::gpu::GpuCompiler::CompileTargetBinary' declared here: different number of parameters (6 vs 7) 266 | virtual absl::StatusOr CompileTargetBinary( ``` This PR fixes the failure by updating the function signature of `CompileTargetBinary` to match the base class. Copybara import of the project: -- 63fd38e18a6194670341dfa9079d0ec47cf2aeb9 by Bhavani Subramanian : Fix build failure in IntelGpuCompiler::CompileTargetBinary Merging this change closes #40331 FUTURE_COPYBARA_INTEGRATE_REVIEW=https://github.com/openxla/xla/pull/40331 from Intel-tensorflow:bhavanis/oneapi-build-fix 63fd38e18a6194670341dfa9079d0ec47cf2aeb9 PiperOrigin-RevId: 894161828 --- xla/service/gpu/intel_gpu_compiler.cc | 2 +- xla/service/gpu/intel_gpu_compiler.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xla/service/gpu/intel_gpu_compiler.cc b/xla/service/gpu/intel_gpu_compiler.cc index f3383ac824b1a..6c7ddc7198c19 100644 --- a/xla/service/gpu/intel_gpu_compiler.cc +++ b/xla/service/gpu/intel_gpu_compiler.cc @@ -54,7 +54,7 @@ IntelGpuCompiler::CompileTargetBinary( const HloModuleConfig& module_config, llvm::Module* llvm_module, const stream_executor::DeviceDescription& device_description, bool relocatable, const HloModule* debug_module, - const CompileOptions& options, std::optional shard_number) { + std::optional shard_number) { TF_ASSIGN_OR_RETURN( auto spirv_str, spirv::CompileToSPIRV(llvm_module, diff --git a/xla/service/gpu/intel_gpu_compiler.h b/xla/service/gpu/intel_gpu_compiler.h index 69d87f4f5a124..c74d9416b35fd 100644 --- a/xla/service/gpu/intel_gpu_compiler.h +++ b/xla/service/gpu/intel_gpu_compiler.h @@ -54,7 +54,7 @@ class IntelGpuCompiler : public GpuCompiler { const HloModuleConfig& module_config, llvm::Module* llvm_module, const stream_executor::DeviceDescription& device_description, bool relocatable, const HloModule* debug_module, - const CompileOptions& options, std::optional shard_number) override; + std::optional shard_number) override; std::vector GetLLVMCommandLineOptions( const DebugOptions& debug_options) const override;