[forge] Failed to add exaltation chest to player

[gabrielew]

Priority

Medium

Area

• Datapack
• Source
• Map
• Other

What happened?

The current method of free space validation during forging is flawed, even when a container is almost empty, the script only checks the main container. Currently, the method removes all the resources required to perform the fusion, but fails when attempting to add the exaltation chest.

Used branch main to test.

[2025-20-10 14:57:31.094] [error] Failed to add exaltation chest to player with name mser

What OS are you seeing the problem on?

Windows

Code of Conduct

• I agree to follow this project's Code of Conduct

[lBaah]

https://github.com/opentibiabr/canary/blob/main/src/creatures/players/player.cpp#L9755

you can move this check up before the removal of anything or you can do queryAdd/queryDestination to player/container, make sure there are slots available, etc

something like this should help you with this bug

void Player::forgeFuseItems(ForgeAction_t actionType, uint16_t firstItemId, uint8_t tier, uint16_t secondItemId, bool success, bool reduceTierLoss, bool convergence, uint8_t bonus, uint8_t coreCount) {
	if (getFreeBackpackSlots() == 0) {
		sendCancelMessage(RETURNVALUE_NOTENOUGHROOM);
		return;
	}

	const auto &exaltationChest = Item::CreateItem(ITEM_EXALTATION_CHEST, 1);
	if (!exaltationChest) {
		g_logger().error("Failed to create exaltation chest");
		sendForgeError(RETURNVALUE_CONTACTADMINISTRATOR);
		return;
	}
	const auto &exaltationContainer = exaltationChest->getContainer();
	if (!exaltationContainer) {
		g_logger().error("Failed to create exaltation container");
		sendForgeError(RETURNVALUE_CONTACTADMINISTRATOR);
		return;
	}

	if (g_game().internalAddItem(static_self_cast<Player>(), exaltationContainer, INDEX_WHEREEVER) != RETURNVALUE_NOERROR) {
		g_logger().error("Failed to add exaltation chest to player with name {}", getName());
		sendCancelMessage(getReturnMessage(returnValue));
		sendForgeError(RETURNVALUE_CONTACTADMINISTRATOR);
		return;
	}
(...)

this will stop execution if exaltation container cannot be added, so nothing will be removed or lost