AssertJ: Refactor assertThat with < or > in the expression to assertThat(actual).isGreaterThan(expected) or assertThat(actual).isLessThan(expected) #814
Description
What problem are you trying to solve?
Using the AssertJ best practices Sonar complains about the following:
What precondition(s) should be checked before applying this recipe?
AssertJ available
Describe the situation before applying the recipe
class A {
void foo(Long bar, Long foo) {
assertThat(bar > 0).isTrue();
assertThat(foo < 0).isTrue();
}
}Describe the situation after applying the recipe
class A {
void foo(Long bar, Long foo) {
assertThat(bar).isGreaterThan(0);
assertThat(foo).isLessThan(0);
}
}Have you considered any alternatives or workarounds?
IDEA does not have quickfix for this, requires manual intervention.
Any additional context
This was a result after transforming this expression from Junit5
class A {
void foo(Long bar, Long foo) {
assertTrue(bar > 0);
assertTrue(foo < 0);
}
}Are you interested in contributing this recipe to OpenRewrite?
Unfortunately I do not have the capacity for it right now.