Skip to content

improper language codes returned in some data sets #69

@lwhiteley

Description

@lwhiteley

eg.
request: SchoolHolidays?countryIsoCode=CH&validFrom=2026-03-10&validTo=2027-03-09

comment entry with "language": " o", seems out of place

"comment": [
  {
    "language": "DE",
    "text": "deutschsprachig"
  },

  {
    "language": " o",
    "text": "ne Tourismusgemeinden"
  },

  {
    "language": "FR",
    "text": "germanophone"
  },

  {
    "language": "EN",
    "text": "German-speaking"
  }
]

Notes (extra context):

  • zod was used on the receiving end to strongly parse the data and found these discrepancies
  • had to remove the strong schema for the iso code for now

https://github.com/openpotato/openholidaysapi.data/blob/65673ec67926c7819deac742ed78ae548d83272c/src/ch/holidays/holidays.school.vs.csv#L76

d588c426-dd25-4b50-9eb2-7a31f8574688;CH;2026-02-21;2026-03-08;School;Regional;DE Sport,FR Sport,IT Sport,EN Sport;VS;DE deutschsprachig, ohne Tourismusgemeinden,FR germanophone,EN German-speaking

DE deutschsprachig, ohne Tourismusgemeinden

either the comma is not escaped properly or it shouldnt be there.

what is intended to be said in german there?

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions