From 4dbb3d3689040f6a419030addd755fff0e13be9c Mon Sep 17 00:00:00 2001
From: Moritz Horn <moritz.horn@gbv.de>
Date: Thu, 4 Dec 2025 18:54:01 +0100
Subject: [PATCH] handle concatinated publisher info

---
 .../org/gokb/TitleAugmentService.groovy       | 73 ++++++++++++-------
 1 file changed, 45 insertions(+), 28 deletions(-)

diff --git a/server/grails-app/services/org/gokb/TitleAugmentService.groovy b/server/grails-app/services/org/gokb/TitleAugmentService.groovy
index 362ad4226..f537fc76d 100644
--- a/server/grails-app/services/org/gokb/TitleAugmentService.groovy
+++ b/server/grails-app/services/org/gokb/TitleAugmentService.groovy
@@ -878,42 +878,59 @@ class TitleAugmentService {
   public void addPublisher (publisher_name, ti, boolean create = false) {
     if (publisher_name != null && publisher_name.trim()) {
       log.debug("Add publisher ${publisher_name}")
-      Org publisher = Org.findByName(publisher_name)
-      def norm_pub_name = Org.generateNormname(publisher_name);
-      def status_deleted = RefdataCategory.lookup("KBComponent.Status", "Deleted")
-      def combo_type_pub = RefdataCategory.lookup("TitleInstance.Publisher")
 
-      if (!publisher) {
-        // Lookup using norm name.
-        log.debug("Using normname ${norm_pub_name} for lookup")
-        publisher = Org.findByNormname(norm_pub_name)
-      }
+      List split_vals = publisher_name.split(';')
+      List candidates = []
 
-      if (!publisher || publisher.status == status_deleted) {
-        def variant_normname = GOKbTextUtils.normaliseString(publisher_name)
-        def candidate_orgs = Org.executeQuery('''select distinct o from Org as o join o.variantNames as v
-                                              where v.normVariantName = :nvn
-                                              and o.status != :sd''',
-                                              [nvn: variant_normname, sd: status_deleted])
+      split_vals.each { raw_val ->
+        String cleaned_val = raw_val.trim()
 
-        if (candidate_orgs.size() == 1) {
-          publisher = candidate_orgs[0]
-        } else {
-          log.debug("Unable to match unique pub ${publisher_name}")
+        if (publisher_name.contains(' (')) {
+          cleaned_val = publisher_name.split(' (')[0]
+        }
+
+        Org publisher = Org.findByName(cleaned_val)
+
+        String norm_pub_name = Org.generateNormname(cleaned_val)
+        RefdataValue status_deleted = RefdataCategory.lookup("KBComponent.Status", "Deleted")
+        RefdataValue combo_type_pub = RefdataCategory.lookup("TitleInstance.Publisher")
+
+        if (!publisher) {
+          // Lookup using norm name.
+          log.debug("Using normname ${norm_pub_name} for lookup")
+          publisher = Org.findByNormname(norm_pub_name)
         }
-      }
 
-      log.debug("Found publisher ${publisher}")
+        if (!publisher || publisher.status == status_deleted) {
+          String variant_normname = GOKbTextUtils.normaliseString(cleaned_val)
+          def candidate_orgs = Org.executeQuery('''select distinct o from Org as o join o.variantNames as v
+                                                where v.normVariantName = :nvn
+                                                and o.status != :sd''',
+                                                [nvn: variant_normname, sd: status_deleted])
 
-      def existing_combos = Combo.executeQuery("from Combo where fromComponent = :ti and toComponent = :pub and type = :ct", [ti: ti, pub: publisher, ct: combo_type_pub])
+          if (candidate_orgs.size() == 1) {
+            publisher = candidate_orgs[0]
+          } else {
+            log.debug("Unable to match unique pub ${cleaned_val}")
+          }
+        }
+
+        log.debug("Found publisher ${publisher}")
+
+        def existing_combos = Combo.executeQuery("from Combo where fromComponent = :ti and toComponent = :pub and type = :ct", [ti: ti, pub: publisher, ct: combo_type_pub])
+
+        if (publisher && existing_combos.size() == 0) {
+          // new Combo(fromComponent: ti, toComponent: publisher, type: combo_type_pub).save(flush: true, failOnError: true)
+          candidates << publisher
+          log.debug("Added new publisher to candidates..")
+        } else {
+          log.debug("Not adding dupe")
+        }
+      }
 
-      if (publisher && existing_combos.size() == 0) {
-        // new Combo(fromComponent: ti, toComponent: publisher, type: combo_type_pub).save(flush: true, failOnError: true)
-        ti.publisher << publisher
+      if (candidates) {
+        ti.publisher << candidates[0]
         ti.save(flush: true)
-        log.debug("Added new publisher ..")
-      } else {
-        log.debug("Not adding dupe")
       }
     }
     else {