-
Notifications
You must be signed in to change notification settings - Fork 15
Description
Sería añadir comillas a las variables:
$variable --> "$variable"
Esta es la explicación de esto:
https://github.com/koalaman/shellcheck/wiki/SC2086
Adjunto archivo corregido
OpenGnsys/installer/opengnsys_import.sh
Line 25 in 69fd9c1
| PROG="$(basename $0)" |
PROG="$(basename "$0")"
OpenGnsys/installer/opengnsys_import.sh
Line 67 in 69fd9c1
| set -- $options |
"$options"
OpenGnsys/installer/opengnsys_import.sh
Line 98 in 69fd9c1
| rm -f $MYCNF |
"$MYCNF"
OpenGnsys/installer/opengnsys_import.sh
Line 110 in 69fd9c1
| DATETIME=`getDateTime` |
"$LOG_FILE"
OpenGnsys/installer/opengnsys_import.sh
Line 111 in 69fd9c1
| echo "$DATETIME;$SSH_CLIENT;$1" >> $LOG_FILE |
echo "$DATETIME;$SSH_CLIENT;$1" >> "$LOG_FILE"
OpenGnsys/installer/opengnsys_import.sh
Line 118 in 69fd9c1
| echo "$DATETIME;$SSH_CLIENT;ERROR: $1" >> $LOG_FILE |
echo "$DATETIME;$SSH_CLIENT;ERROR: $1" >> "$LOG_FILE"
OpenGnsys/installer/opengnsys_import.sh
Line 135 in 69fd9c1
| cat << EOT > $MYCNF |
cat << EOT > "$MYCNF"
OpenGnsys/installer/opengnsys_import.sh
Line 164 in 69fd9c1
| OLDVERSION="$(echo ${file%.*} | cut -f3 -d-)" |
OLDVERSION="$(echo "${file%.*}" | cut -f3 -d-)"
OpenGnsys/installer/opengnsys_import.sh
Line 177 in 69fd9c1
| if [ -n "$FILES" -o "$OLDVERSION" = "$NEWVERSION" ] && [ -r $file ]; then |
if [ -n "$FILES" -o "$OLDVERSION" = "$NEWVERSION" ] && [ -r "$file" ]; then
OpenGnsys/installer/opengnsys_import.sh
Line 183 in 69fd9c1
| mysql --defaults-extra-file=$MYCNF -e "CREATE DATABASE $AUXCATALOG" |
mysql --defaults-extra-file="$MYCNF" -e "CREATE DATABASE $AUXCATALOG"
OpenGnsys/installer/opengnsys_import.sh
Line 185 in 69fd9c1
| mysql --defaults-extra-file=$MYCNF -D "$AUXCATALOG" < $MYSQLFILE &>/dev/null |
mysql --defaults-extra-file="$MYCNF" -D "$AUXCATALOG" < $MYSQLFILE &>/dev/null
OpenGnsys/installer/opengnsys_import.sh
Line 189 in 69fd9c1
| importSqlFile $DBDIR/$file |
importSqlFile $DBDIR/"$file"
OpenGnsys/installer/opengnsys_import.sh
Line 189 in 69fd9c1
| importSqlFile $DBDIR/$file |
mysqldump --defaults-extra-file="$MYCNF" --opt $AUXCATALOG > $MYSQLFILE
OpenGnsys/installer/opengnsys_import.sh
Line 196 in 69fd9c1
| mysql --defaults-extra-file=$MYCNF -e "DROP DATABASE $AUXCATALOG" |
mysql --defaults-extra-file="$MYCNF" -e "DROP DATABASE $AUXCATALOG"
OpenGnsys/installer/opengnsys_import.sh
Line 209 in 69fd9c1
| if [ ! -r $sqlfile ]; then |
if [ ! -r "$sqlfile" ]; then
OpenGnsys/installer/opengnsys_import.sh
Line 216 in 69fd9c1
| mysql --defaults-extra-file=$MYCNF --default-character-set=utf8 -D "$AUXCATALOG" < $sqlfile |
mysql --defaults-extra-file="$MYCNF" --default-character-set=utf8 -D "$AUXCATALOG" < "$sqlfile"
OpenGnsys/installer/opengnsys_import.sh
Line 259 in 69fd9c1
| echo $CONFIG | jq -r '.[] as $f | $f.comment + ": " + (if $f.detected then "OK" else "FAIL" end)' | column -ts: |
echo "$CONFIG" | jq -r '.[] as $f | $f.comment + ": " + (if $f.detected then "OK" else "FAIL" end)' | column -ts:
OpenGnsys/installer/opengnsys_import.sh
Line 275 in 69fd9c1
| if ! [ -r $BACKUPFILE ]; then |
if ! [ -r "$BACKUPFILE" ]; then
OpenGnsys/installer/opengnsys_import.sh
Line 276 in 69fd9c1
| echo "$PROG: ERROR: Sin acceso al fichero de backup." | tee -a $FILESAL |
echo "$PROG: ERROR: Sin acceso al fichero de backup." | tee -a "$FILESAL"
OpenGnsys/installer/opengnsys_import.sh
Line 282 in 69fd9c1
| echo "$PROG: ERROR: Sin acceso a la configuración de OpenGnsys." | tee -a $FILESAL |
echo "$PROG: ERROR: Sin acceso a la configuración de OpenGnsys." | tee -a "$FILESAL"
OpenGnsys/installer/opengnsys_import.sh
Line 294 in 69fd9c1
| checkArchive $BACKUPFILE |
checkArchive "$BACKUPFILE"
OpenGnsys/installer/opengnsys_import.sh
Line 302 in 69fd9c1
| tar -xvzf $BACKUPFILE --directory /tmp $TARPARAMS &>/dev/null |
tar -xvzf "$BACKUPFILE" --directory /tmp $TARPARAMS &>/dev/null
OpenGnsys/installer/opengnsys_import.sh
Line 316 in 69fd9c1
| if [ $OLDVERSION != $NEWVERSION ] ; then |
if [ "$OLDVERSION" != "$NEWVERSION" ] ; then
OpenGnsys/installer/opengnsys_import.sh
Line 339 in 69fd9c1
| if [ ! -r $MYCNF ]; then |
if [ ! -r "$MYCNF" ]; then
OpenGnsys/installer/opengnsys_import.sh
Line 340 in 69fd9c1
| chmod 600 $MYCNF |
chmod 600 "$MYCNF"
OpenGnsys/installer/opengnsys_import.sh
Line 342 in 69fd9c1
| cat << EOT > $MYCNF |
cat << EOT > "$MYCNF"
OpenGnsys/installer/opengnsys_import.sh
Line 373 in 69fd9c1
| mysqldump --defaults-extra-file=$MYCNF --opt $CATALOG > $MYSQLBCK |
mysqldump --defaults-extra-file="$MYCNF" --opt $CATALOG > "$MYSQLBCK"
OpenGnsys/installer/opengnsys_import.sh
Line 374 in 69fd9c1
| chmod 400 $MYSQLBCK |
chmod 400 "$MYSQLBCK"
OpenGnsys/installer/opengnsys_import.sh
Line 376 in 69fd9c1
| mysql --defaults-extra-file=$MYCNF -D "$CATALOG" < $MYSQLFILE &>/dev/null |
mysql --defaults-extra-file="$MYCNF" -D "$CATALOG" < $MYSQLFILE &>/dev/null
OpenGnsys/installer/opengnsys_import.sh
Line 382 in 69fd9c1
| mv /etc/default/opengnsys /etc/default/opengnsys-$DATE |
mv /etc/default/opengnsys /etc/default/opengnsys-"$DATE"
OpenGnsys/installer/opengnsys_import.sh
Line 395 in 69fd9c1
| mv $DHCPCFGDIR/dhcpd.conf $DHCPCFGDIR/dhcpd.conf-$DATE |
mv $DHCPCFGDIR/dhcpd.conf $DHCPCFGDIR/dhcpd.conf-"$DATE"
OpenGnsys/installer/opengnsys_import.sh
Line 397 in 69fd9c1
| sed ${BEFOREHOST}q $DHCPCFGDIR/dhcpd.conf-LAST > $DHCPCFGDIR/dhcpd.conf |
sed "${BEFOREHOST}"q $DHCPCFGDIR/dhcpd.conf-LAST > $DHCPCFGDIR/dhcpd.conf
OpenGnsys/installer/opengnsys_import.sh
Line 407 in 69fd9c1
| mkdir -p $OPENGNSYS/tftpboot/$BOOTLOADER-$DATE |
mkdir -p $OPENGNSYS/tftpboot/$BOOTLOADER-"$DATE"
OpenGnsys/installer/opengnsys_import.sh
Line 408 in 69fd9c1
| mv $OPENGNSYS/tftpboot/$BOOTLOADER/{01-*,templates,examples} $OPENGNSYS/tftpboot/$BOOTLOADER-$DATE 2>/dev/null |
mv $OPENGNSYS/tftpboot/$BOOTLOADER/{01-*,templates,examples} $OPENGNSYS/tftpboot/$BOOTLOADER-"$DATE" 2>/dev/null
OpenGnsys/installer/opengnsys_import.sh
Line 421 in 69fd9c1
| mysql --defaults-extra-file=$MYCNF -D "$CATALOG" -e "update ordenadores set arranque='10' where arranque='01';" &>/dev/null |
mysql --defaults-extra-file="$MYCNF" -D "$CATALOG" -e "update ordenadores set arranque='10' where arranque='01';" &>/dev/null
OpenGnsys/installer/opengnsys_import.sh
Line 427 in 69fd9c1
| mv $OPENGNSYS/client/etc/engine.cfg $OPENGNSYS/client/etc/engine.cfg-$DATE |
mv $OPENGNSYS/client/etc/engine.cfg $OPENGNSYS/client/etc/engine.cfg-"$DATE"
OpenGnsys/installer/opengnsys_import.sh
Line 432 in 69fd9c1
| mv $OPENGNSYS/www/menus $OPENGNSYS/www/menus-$DATE |
mv $OPENGNSYS/www/menus $OPENGNSYS/www/menus-"$DATE"
OpenGnsys/installer/opengnsys_import.sh
Line 438 in 69fd9c1
| mkdir -p $OPENGNSYS/client/scripts/Custom-$DATE |
mkdir -p $OPENGNSYS/client/scripts/Custom-"$DATE"
OpenGnsys/installer/opengnsys_import.sh
Line 439 in 69fd9c1
| mv $OPENGNSYS/client/scripts/*Custom $OPENGNSYS/client/scripts/Custom-$DATE |
mv $OPENGNSYS/client/scripts/*Custom $OPENGNSYS/client/scripts/Custom-"$DATE"
OpenGnsys/installer/opengnsys_import.sh
Line 450 in 69fd9c1
| mv $OPENGNSYS/etc/ogliveinfo.json $OPENGNSYS/etc/ogliveinfo.json-$DATE |
mv $OPENGNSYS/etc/ogliveinfo.json $OPENGNSYS/etc/ogliveinfo.json-"$DATE"
Un saludo, simplemente le he pasado el shellcheck