-
Notifications
You must be signed in to change notification settings - Fork 8
Description
The first topic is missing AbstractDescription for some classes in Extension package. The role of those AbstractDescription classes is described in
https://docs.opengeospatial.org/is/16-008/16-008.html#7
But when we created those AbstractDescription, we did them by pulling properties from existing classes and push some other classes altogether in Extension. For those latter classes, we did not bother to create AbstractDescription (because it was the mechanism to push their properties in Extension while remaining in Basic package). This is where we neglected the second role of AbstractDescription: extension points to add more properties. GTK (Finland) spotted the problem when they wanted to create new properties for Fracture.
Check Fracture, Fold System, Lineation and Non-Directional Structure in https://docs.opengeospatial.org/is/16-008/16-008.html#186
There are a couple of solutions
- Move Fracture and Join to basic and add AbstractDescription (major, not bacward compatible for Extension pattern)
- Add AbstractDescription in Extension as point of extension (minor -if AbstractDescription is 0..n)
- Add a top level AbstractDescription to GeologicStructure (all class inherits it, minor but some classes get two AbstractDescription)
Solution 2 was preferred from the people attending the meeting, but someone rose a need for #1 (more classes into Basic). But solution #1 is not backward compatible. Unless there is a strong use case for #1, the general preference is to go with #2.
Is there disagreement ?