Skip to content

Commit f0bc591

Browse files
committed
feat: backward compatibility
1 parent 153261b commit f0bc591

3 files changed

Lines changed: 34 additions & 8 deletions

File tree

openfga_sdk/client/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -555,9 +555,9 @@ async def _write_with_transaction(
555555
writes_tuple_keys = None
556556
deletes_tuple_keys = None
557557
if body.writes:
558-
writes_tuple_keys = body.writes_tuple_keys(on_duplicate=on_duplicate)
558+
writes_tuple_keys = body.get_writes_tuple_keys(on_duplicate=on_duplicate)
559559
if body.deletes:
560-
deletes_tuple_keys = body.deletes_tuple_keys(on_missing=on_missing)
560+
deletes_tuple_keys = body.get_deletes_tuple_keys(on_missing=on_missing)
561561

562562
await self._api.write(
563563
WriteRequest(

openfga_sdk/client/models/write_request.py

Lines changed: 30 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,31 @@ def deletes(self, value: list[ClientTuple] | None) -> None:
5656
"""
5757
self._deletes = value
5858

59-
def writes_tuple_keys(
59+
@property
60+
def writes_tuple_keys(self) -> WriteRequestWrites | None:
61+
"""
62+
Return the writes as tuple keys (backward compatibility property)
63+
"""
64+
return self.get_writes_tuple_keys()
65+
66+
@property
67+
def deletes_tuple_keys(self) -> WriteRequestDeletes | None:
68+
"""
69+
Return the deletes as tuple keys (backward compatibility property)
70+
"""
71+
return self.get_deletes_tuple_keys()
72+
73+
def get_writes_tuple_keys(
6074
self, on_duplicate: str | None = None
6175
) -> WriteRequestWrites | None:
6276
"""
63-
Return the writes as tuple keys
77+
Return the writes as tuple keys with optional conflict handling
78+
79+
Args:
80+
on_duplicate: Optional conflict resolution strategy for duplicate writes
81+
82+
Returns:
83+
WriteRequestWrites object with tuple keys and optional on_duplicate setting
6484
"""
6585
if self._writes is None:
6686
return None
@@ -74,11 +94,17 @@ def writes_tuple_keys(
7494
return WriteRequestWrites(tuple_keys=keys, on_duplicate=on_duplicate)
7595
return WriteRequestWrites(tuple_keys=keys)
7696

77-
def deletes_tuple_keys(
97+
def get_deletes_tuple_keys(
7898
self, on_missing: str | None = None
7999
) -> WriteRequestDeletes | None:
80100
"""
81-
Return the delete as tuple keys
101+
Return the deletes as tuple keys with optional conflict handling
102+
103+
Args:
104+
on_missing: Optional conflict resolution strategy for missing deletes
105+
106+
Returns:
107+
WriteRequestDeletes object with tuple keys and optional on_missing setting
82108
"""
83109
if self._deletes is None:
84110
return None

openfga_sdk/sync/client/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -555,9 +555,9 @@ def _write_with_transaction(
555555
writes_tuple_keys = None
556556
deletes_tuple_keys = None
557557
if body.writes:
558-
writes_tuple_keys = body.writes_tuple_keys(on_duplicate=on_duplicate)
558+
writes_tuple_keys = body.get_writes_tuple_keys(on_duplicate=on_duplicate)
559559
if body.deletes:
560-
deletes_tuple_keys = body.deletes_tuple_keys(on_missing=on_missing)
560+
deletes_tuple_keys = body.get_deletes_tuple_keys(on_missing=on_missing)
561561

562562
self._api.write(
563563
WriteRequest(

0 commit comments

Comments
 (0)