Skip to content

feat(telemetry): add fga-client.request.count metric for tracking HTT…#285

Closed
emilic wants to merge 1 commit intomainfrom
feat/http-req-count
Closed

feat(telemetry): add fga-client.request.count metric for tracking HTT…#285
emilic wants to merge 1 commit intomainfrom
feat/http-req-count

Conversation

@emilic
Copy link

@emilic emilic commented Mar 16, 2026

…P requests

Record a counter metric on every HTTP attempt in recordTelemetry(), alongside the existing request.duration and query.duration metrics. This enables users to track the total number of HTTP requests made by the SDK via OpenTelemetry.

Closes #282

Description

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

…P requests

Record a counter metric on every HTTP attempt in recordTelemetry(),
alongside the existing request.duration and query.duration metrics.
This enables users to track the total number of HTTP requests made
by the SDK via OpenTelemetry.

Closes #282
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9d8aad20-0d34-40be-87be-e8f912a2a996

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/http-req-count
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can validate your CodeRabbit configuration file in your editor.

If your editor has YAML language server, you can enable auto-completion and validation by adding # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json at the top of your CodeRabbit configuration file.

@emilic emilic closed this Mar 16, 2026
@emilic emilic deleted the feat/http-req-count branch March 16, 2026 13:45
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.78%. Comparing base (7e50860) to head (373c600).

Files with missing lines Patch % Lines
telemetry/attributes.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
+ Coverage   33.63%   33.78%   +0.14%     
==========================================
  Files         115      115              
  Lines        9831     9859      +28     
==========================================
+ Hits         3307     3331      +24     
- Misses       6260     6264       +4     
  Partials      264      264              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add fga-client.request.count metric for tracking HTTP requests

2 participants