http and registry proxy on hooks deployment

[recharte]

Note

This issue was originally reported in percona/percona-helm-charts#594.
It has been migrated here as part of the repository move.

Hi !

We use a Harbor proxy for Docker images and an HTTP proxy for outbound HTTP requests.
The upgrade job installs the curl package before downloading the everestctl binary.

In my environment,
apk cannot install the curl package because it requires the HTTP proxies,
and later, curl will also need those proxies to download the binary.

Would it be possible to:

inject the HTTP proxy settings as environment variables,

and make the image configurable,
so we can use a Docker registry proxy as well?

I propose this to you

charts/everest/charts/common/values.yaml

global:
  httpProxy: ""
  httpsProxy: ""
  noProxy: ""

upgrade:
  image: alpine:3.20

kubectl:
  image: bitnami/kubectl:latest

charts/everest/charts/common/templates/_upgrade_checks.yaml.tpl (~line 100)

 containers:
  - image: {{ .Values.upgrade.image | quote }}
    name: {{ $hookName }}
    env:
      {{- if and .Values.global.httpProxy (ne .Values.global.httpProxy "") }}
      - name: HTTP_PROXY
        value: {{ .Values.global.httpProxy | quote }}
      {{- end }}
      {{- if and .Values.global.httpsProxy (ne .Values.global.httpsProxy "") }}
      - name: HTTPS_PROXY
        value: {{ .Values.global.httpsProxy | quote }}
      {{- end }}
      {{- if and .Values.global.noProxy (ne .Values.global.noProxy "") }}
      - name: NO_PROXY
        value: {{ .Values.global.noProxy | quote }}
      {{- end }}

charts/everest/charts/common/templates/_psp_cleanup.yaml.tpl (~line 66)

 containers:
  - image: {{ .Values.kubectl.image | quote }}

charts/everest/charts/common/templates/_operators_installer.yaml.tpl (~line 82)

 containers:
  - image: {{ .Values.kubectl.image | quote }}

charts/everest/charts/common/templates/_db_resources_cleanup.yaml.tpl (~line 69)

 containers:
  - image: {{ .Values.kubectl.image | quote }}

charts/everest/charts/common/templates/_csv_cleanup.yaml.tpl (~line 62)

 containers:
  - image: {{ .Values.kubectl.image | quote }}

edit: missing files for kubectl cli

[recharte]

The original issue suggested a few things that have already been done in other issues/PRs:

• Expose kubectl image:
  • Exposed in: EVEREST-2303 | Move from bitnami/kubectl image percona/percona-helm-charts#636
  • And update to our own image in: EVEREST-2303 | use percona/everest-helmtools for hook jobs percona/percona-helm-charts#642
• Ensure upgrade image doesn't need to download everestctl: Helm Chart Modification for Offline/Internal Network Environments #13

Therefore, this issue should focus on exposing the proxy vars httpProxy, httpsProxy, noProxy.