-
Notifications
You must be signed in to change notification settings - Fork 17
fix: Avoid exception when migrating read states #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When a thread is deleted, a read state may be retained pointing to a non-existent thread. This may cause a `DoesNotExist` exception during migration of read states.
|
Thanks for the pull request, @angonz! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@angonz Could you remove the |
| str: A truncated title string with length less than 1025 characters. | ||
| """ | ||
| # Remove emojis from the title | ||
| title = ''.join(char for char in title if unicodedata.category(char)[0] != 'S') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Oh! My apologies, I didn't realize this PR was closed, @angonz -- since the issue was still open and linked here. Was this resolved some other way? I'm still getting the errors on my end, so I went to look over your solution. |
When a thread is deleted, a read state may be retained pointing to a non-existent thread. This may cause a
DoesNotExistexception during migration of readstates.
Merge checklist:
Check off if complete or not applicable: