Skip to content

Conversation

@angonz
Copy link

@angonz angonz commented May 5, 2025

When a thread is deleted, a read state may be retained pointing to a non-existent thread. This may cause a DoesNotExist exception during migration of read
states.

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

When a thread is deleted, a read state may be retained
pointing to a non-existent thread. This may cause a
`DoesNotExist` exception during migration of read
states.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 5, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @angonz!

This repository is currently maintained by @openedx/wg-maintainers-forums.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@angonz angonz closed this May 22, 2025
@angonz angonz deleted the angonz/fix-read-state-migration branch May 22, 2025 19:02
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions May 22, 2025
@Kelketek
Copy link

@angonz Could you remove the .idea directory from this PR? Feel free to add it to the .gitignore since it's a very common IDE scratch directory.

str: A truncated title string with length less than 1025 characters.
"""
# Remove emojis from the title
title = ''.join(char for char in title if unicodedata.category(char)[0] != 'S')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angonz This isn't mentioned in the PR description, nor in #177 . Is it intended to be included, or is this something specific to your use case?

@Kelketek
Copy link

Oh! My apologies, I didn't realize this PR was closed, @angonz -- since the issue was still open and linked here. Was this resolved some other way? I'm still getting the errors on my end, so I went to look over your solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants