container stop operation also removed the container

[NoaKirsh]

Hi,
Why does stop container operation also contain remove operation?

in https://github.com/openconfig/containerz/blob/master/containers/docker/container_stop.go:

if err := m.client.ContainerStop(ctx, instance, container.StopOptions{Timeout: pDuration}); err != nil {
   ...

if err := m.client.ContainerRemove(ctx, instance, container.RemoveOptions{
   ...

The container with the stopped status should still exist in the container list.

[alshabib]

Good question - it was added to make the implementation of start simpler. If we do not remove the container then we check whether the container exists before starting one in the start operation. This would require a spec change to describe this behaviour.

Is this something needed for your use case? If yes, I am happy to discuss the needed changes in more detail.

[NoaKirsh]

If we do not remove the container then we check whether the container exists before starting one in the start operation.

It makes sense to do this.
Otherwise, what is the difference between container stop and container remove?
I agree, adding the check you mentioned in container start is needed for that.