From 2fcff1ef0092198cf6d7c764ac9b314ec051c6dc Mon Sep 17 00:00:00 2001 From: Hannah von Reth Date: Thu, 6 Feb 2025 12:15:39 +0100 Subject: [PATCH] Assert if we fail to find a space --- src/gui/folder.cpp | 7 +++---- src/gui/folder.h | 1 - 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/gui/folder.cpp b/src/gui/folder.cpp index 3ff494b32e..f0bad66908 100644 --- a/src/gui/folder.cpp +++ b/src/gui/folder.cpp @@ -353,10 +353,9 @@ bool Folder::isSyncRunning() const QUrl Folder::webDavUrl() const { const QString spaceId = _definition.spaceId(); - if (!spaceId.isEmpty()) { - if (auto *space = _accountState->account()->spacesManager()->space(spaceId)) { - return QUrl(space->drive().getRoot().getWebDavUrl()); - } + Q_ASSERT(!spaceId.isEmpty()); + if (auto *space = _accountState->account()->spacesManager()->space(spaceId); OC_ENSURE(space)) { + return QUrl(space->drive().getRoot().getWebDavUrl()); } return _definition.webDavUrl(); } diff --git a/src/gui/folder.h b/src/gui/folder.h index 5149ef9784..fb3e640e99 100644 --- a/src/gui/folder.h +++ b/src/gui/folder.h @@ -115,7 +115,6 @@ class OPENCLOUD_GUI_EXPORT FolderDefinition private: FolderDefinition(const QByteArray &id, const QUrl &davUrl, const QString &spaceId, const QString &displayName); - // oc10 and as cache for ocis QUrl _webDavUrl; QString _spaceId;