refactor(ofrep): use elif chain and _HTTP_AUTH_ERRORS dict in _raise_for_http_status

Author: thomaspoignant

providers/openfeature-provider-ofrep/src/openfeature/contrib/provider/ofrep/__init__.py

@@ -42,6 +42,8 @@
     ],
 ]
 
+_HTTP_AUTH_ERRORS: dict[int, str] = {401: "unauthorized", 403: "forbidden"}
+
 
 class OFREPProvider(AbstractProvider):
     def __init__(
@@ -183,57 +185,46 @@ def _handle_error(self, exception: requests.RequestException) -> NoReturn:
         except JSONDecodeError:
             raise ParseError(str(exception)) from exception
 
-        self._raise_for_error_code(data, exception)
+        error_code = ErrorCode(data["errorCode"])
+        error_details = data["errorDetails"]
+
+        if error_code == ErrorCode.PARSE_ERROR:
+            raise ParseError(error_details) from exception
+        if error_code == ErrorCode.TARGETING_KEY_MISSING:
+            raise TargetingKeyMissingError(error_details) from exception
+        if error_code == ErrorCode.INVALID_CONTEXT:
+            raise InvalidContextError(error_details) from exception
+        if error_code == ErrorCode.GENERAL:
+            raise GeneralError(error_details) from exception
+
+        raise OpenFeatureError(error_code, error_details) from exception
 
     def _raise_for_http_status(
         self,
         response: requests.Response,
         exception: requests.RequestException,
     ) -> None:
-        if response.status_code == 429:
+        status = response.status_code
+
+        if status == 429:
             retry_after = response.headers.get("Retry-After")
             self.retry_after = _parse_retry_after(retry_after)
             raise GeneralError(
                 f"Rate limited, retry after: {retry_after}"
             ) from exception
-
-        if response.status_code == 401:
-            raise OpenFeatureError(ErrorCode.GENERAL, "unauthorized") from exception
-
-        if response.status_code == 403:
-            raise OpenFeatureError(ErrorCode.GENERAL, "forbidden") from exception
-
-        if response.status_code == 404:
+        elif status in _HTTP_AUTH_ERRORS:
+            raise OpenFeatureError(
+                ErrorCode.GENERAL, _HTTP_AUTH_ERRORS[status]
+            ) from exception
+        elif status == 404:
             try:
-                data = response.json()
-                error_details = data["errorDetails"]
-            except JSONDecodeError:
+                error_details = response.json()["errorDetails"]
+            except (JSONDecodeError, KeyError):
                 error_details = response.text
             raise FlagNotFoundError(error_details) from exception
-
-        if response.status_code > 400:
+        elif status > 400:
             raise OpenFeatureError(ErrorCode.GENERAL, response.text) from exception
 
-    def _raise_for_error_code(
-        self,
-        data: dict[str, Any],
-        exception: requests.RequestException,
-    ) -> NoReturn:
-        error_code = ErrorCode(data["errorCode"])
-        error_details = data["errorDetails"]
-
-        if error_code == ErrorCode.PARSE_ERROR:
-            raise ParseError(error_details) from exception
-        if error_code == ErrorCode.TARGETING_KEY_MISSING:
-            raise TargetingKeyMissingError(error_details) from exception
-        if error_code == ErrorCode.INVALID_CONTEXT:
-            raise InvalidContextError(error_details) from exception
-        if error_code == ErrorCode.GENERAL:
-            raise GeneralError(error_details) from exception
-
-        raise OpenFeatureError(error_code, error_details) from exception
-
-
 def _build_request_data(
     evaluation_context: Optional[EvaluationContext],
 ) -> dict[str, Any]: