Skip to content

Commit d3b3256

Browse files
THuvarakiTHuvaraki
authored andcommitted
Issues fixed
Signed-off-by: THuvaraki <Thuvaraki.E@cloudsolutions.com.sa>
1 parent 0c78211 commit d3b3256

5 files changed

Lines changed: 29 additions & 50 deletions

File tree

api/core/v1beta1/featureflag_types.go

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -32,26 +32,20 @@ type FeatureFlagSpec struct {
3232

3333
type FlagSpec struct {
3434
Flags `json:",inline"`
35-
// Metadata holds optional flag-level metadata such as flag set identifiers.
36-
// Additional metadata keys are preserved to support flagd metadata inheritance.
3735
// +optional
36+
// +kubebuilder:validation:Schemaless
3837
// +kubebuilder:pruning:PreserveUnknownFields
39-
Metadata *FlagMetadata `json:"metadata,omitempty"`
38+
// +kubebuilder:validation:Type=object
39+
// Metadata holds optional flag-set level metadata.
40+
// Additional metadata keys are preserved to support flagd metadata inheritance.
41+
Metadata json.RawMessage `json:"metadata,omitempty"`
4042
// +optional
4143
// +kubebuilder:validation:Schemaless
4244
// +kubebuilder:pruning:PreserveUnknownFields
4345
// +kubebuilder:validation:Type=object
4446
Evaluators json.RawMessage `json:"$evaluators,omitempty"`
4547
}
4648

47-
// FlagMetadata captures optional metadata for a flag specification.
48-
// PreserveUnknownFields keeps compatibility with flagd's metadata inheritance model.
49-
// +kubebuilder:pruning:PreserveUnknownFields
50-
type FlagMetadata struct {
51-
// +optional
52-
FlagSetID string `json:"flagSetId,omitempty"`
53-
}
54-
5549
// Flags represent the flags specification
5650
type Flags struct {
5751
FlagsMap map[string]Flag `json:"flags"`
@@ -60,20 +54,24 @@ type Flags struct {
6054
type Flag struct {
6155
// +kubebuilder:validation:Enum=ENABLED;DISABLED
6256
State string `json:"state"`
63-
// +optional
64-
// +kubebuilder:pruning:PreserveUnknownFields
65-
Metadata *FlagMetadata `json:"metadata,omitempty"`
6657
// +kubebuilder:validation:Schemaless
6758
// +kubebuilder:pruning:PreserveUnknownFields
6859
// +kubebuilder:validation:Type=object
69-
Variants json.RawMessage `json:"variants"`
70-
DefaultVariant string `json:"defaultVariant"`
60+
Variants json.RawMessage `json:"variants"`
61+
DefaultVariant string `json:"defaultVariant"`
7162
// +optional
7263
// +kubebuilder:validation:Schemaless
7364
// +kubebuilder:pruning:PreserveUnknownFields
7465
// +kubebuilder:validation:Type=object
7566
// Targeting is the json targeting rule
7667
Targeting json.RawMessage `json:"targeting,omitempty"`
68+
// +optional
69+
// +kubebuilder:validation:Schemaless
70+
// +kubebuilder:pruning:PreserveUnknownFields
71+
// +kubebuilder:validation:Type=object
72+
// Metadata holds optional per-flag metadata.
73+
// Additional metadata keys are preserved to support flagd metadata inheritance.
74+
Metadata json.RawMessage `json:"metadata,omitempty"`
7775
}
7876

7977
// FeatureFlagStatus defines the observed state of FeatureFlag
@@ -135,4 +133,4 @@ func (ff *FeatureFlag) GenerateConfigMap(name string, namespace string, referenc
135133
common.FeatureFlagConfigMapKey(namespace, name): string(b),
136134
},
137135
}, nil
138-
}
136+
}

api/core/v1beta1/zz_generated.deepcopy.go

Lines changed: 7 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/core.openfeature.dev_featureflags.yaml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,8 @@ spec:
5555
type: string
5656
metadata:
5757
description: |-
58-
FlagMetadata captures optional metadata for a flag specification.
59-
PreserveUnknownFields keeps compatibility with flagd's metadata inheritance model.
60-
properties:
61-
flagSetId:
62-
type: string
58+
Metadata holds optional per-flag metadata.
59+
Additional metadata keys are preserved to support flagd metadata inheritance.
6360
type: object
6461
x-kubernetes-preserve-unknown-fields: true
6562
state:
@@ -82,11 +79,8 @@ spec:
8279
type: object
8380
metadata:
8481
description: |-
85-
Metadata holds optional flag-level metadata such as flag set identifiers.
82+
Metadata holds optional flag-set level metadata.
8683
Additional metadata keys are preserved to support flagd metadata inheritance.
87-
properties:
88-
flagSetId:
89-
type: string
9084
type: object
9185
x-kubernetes-preserve-unknown-fields: true
9286
required:

config/manager/kustomization.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@ configMapGenerator:
1414

1515
images:
1616
- name: controller
17-
newName: open-feature-operator-local
18-
newTag: validate
17+
newName: ghcr.io/openfeature/operator
18+
newTag: latest

go.mod

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,4 +108,6 @@ require (
108108
sigs.k8s.io/yaml v1.4.0 // indirect
109109
)
110110

111+
replace github.com/open-feature/open-feature-operator/apis => ./api
112+
111113
replace golang.org/x/net => golang.org/x/net v0.27.0

0 commit comments

Comments
 (0)