Skip to content

Commit f18e2b4

Browse files
committed
fix: drop error-message step and fix evaluator gherkin conventions
Remove 'error message should contain' step (new step def, adds friction). Fix evaluator suite to use 'a fallback value' instead of 'a default value'. Add missing 'Given an evaluator' to new evaluator scenarios. Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
1 parent 3206bd1 commit f18e2b4

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

evaluator/gherkin/evaluator-refs.feature

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ Feature: Evaluator evaluator refs
1616

1717
@evaluator-refs @evaluator-refs-whitespace
1818
Scenario Outline: Evaluator $ref resolves regardless of whitespace around the colon
19-
Given a String-flag with key "<key>" and a default value "fallback"
19+
Given an evaluator
20+
And a String-flag with key "<key>" and a fallback value "fallback"
2021
And a context containing a key "email", with type "String" and with value "<email>"
2122
When the flag was evaluated with details
2223
Then the resolved details value should be "<value>"
@@ -32,8 +33,8 @@ Feature: Evaluator evaluator refs
3233

3334
@evaluator-refs @non-existent-evaluator-ref
3435
Scenario: Ref to nonexistent evaluator yields parse error
35-
Given a String-flag with key "ref-to-nonexistent-evaluator-flag" and a default value "fallback"
36+
Given an evaluator
37+
And a String-flag with key "ref-to-nonexistent-evaluator-flag" and a fallback value "fallback"
3638
When the flag was evaluated with details
3739
Then the resolved details value should be "fallback"
3840
And the error-code should be "PARSE_ERROR"
39-
And the error message should contain "nonexistent_evaluator"

gherkin/targeting.feature

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ Feature: Targeting rules
4242
When the flag was evaluated with details
4343
Then the resolved details value should be "fallback"
4444
And the error-code should be "PARSE_ERROR"
45-
And the error message should contain "nonexistent_evaluator"
4645

4746
# custom operators
4847
# @fractional-v1: legacy float-based bucketing (abs(hash) / i32::MAX * 100)

0 commit comments

Comments
 (0)