fix: dataclass should not modify raw dict (#425)

Author: leavesster

oocana/oocana/handle.py

@@ -1,6 +1,7 @@
 from dataclasses import dataclass, field
 from typing import Any, Optional
 from .schema import FieldSchema, ContentMediaType
+import copy
 
 __all__ = ["HandleDef", "InputHandleDef", "OutputHandleDef"]
 
@@ -45,12 +46,15 @@ class HandleDef(DataDict):
 
     def __init__(self, **kwargs):
         for key, value in kwargs.items():
-            object.__setattr__(self, key, value)
+            if key == 'json_schema' and isinstance(value, dict):
+                object.__setattr__(self, key, copy.deepcopy(value))
+            else:   # For other attributes, we can use the default behavior of object.__setattr__
+                object.__setattr__(self, key, value)
         if "handle" not in kwargs:
             raise ValueError("missing attr key: 'handle'")
         json_schema = self.json_schema
         if json_schema is not None and not isinstance(json_schema, FieldSchema):
-            object.__setattr__(self, "_raw_json_schema", json_schema)
+            object.__setattr__(self, "_raw_json_schema", copy.deepcopy(json_schema))
             object.__setattr__(self, "json_schema", FieldSchema.generate_schema(json_schema))
 
     def check_handle_type(self, type: ContentMediaType) -> bool:

oocana/tests/test_handle.py

@@ -208,6 +208,22 @@ def test_serializable_var_output_handle(self):
             "need_serialize_var_for_cache": True
         })
 
+    def test_json_schema(self):
+        """Test that json schema can be converted to dict."""
+        d = {
+            "handle": "test",
+            "json_schema": {
+                "type": "object",
+                "properties": {
+                    "name": { "type": "string" },
+                    "age": { "type": "number" }
+                },
+            }
+        }
+        handle_def = HandleDef(**d)
+        self.assertEqual(handle_def.json_schema_to_dict(), d["json_schema"])
+        self.assertIsInstance(d["json_schema"]["properties"]["name"], dict)
+
     def test_var_handle(self):
         self.handle_test(HandleDef(**var_handle), {
             "handle": "test",