Skip to content

[Crash] Unchecked this.room.itemManager.collectItem in pickupItem #55

@coderabbitai

Description

@coderabbitai

Summary

Game server crashes when this.room.itemManager is undefined during item pickup.

Affected Code

server-game/src/client.js:653

pickupItem (kind, weaponIdx, id) {
  this.room.itemManager.collectItem(kind, id); // CRASH if itemManager is undefined

Vulnerability

If room initialization incomplete or during shutdown.

Impact

  • Game server crash on item pickup
  • Denial of service

Recommended Fix

this.room.itemManager?.collectItem(kind, id);

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions