FLOW-2 Panicking Autobalancer May Cause a Dos for the Supervisor Recovery Loop

[vishalchangrani]

• Needs confirmation/further investigation
• We did think about this issue earlier and separated out rebalances

[holyfuchs]

The issue is valid, if any AutoBalancer panics (rather than returning an error), the entire transaction reverts, preventing
recovery of all other pending vaults.

However this is limited towards that block and a call to FlowYieldVaultsSchedulerRegistry.unregister removes the vault from the pending queue, fixing the issue for future runs.
ScheduleNextRebalance is already implemented to fail gracefully.

I wouldn't see how its possible to add a retry counter easily, and I don't think the additional overhead and complexity is worth it.

[vishalchangrani]

@Kay-Zee @nialexsan -do you agree with @holyfuchs conclusion? If yes, then we can close this issue.