Why themeing require to copy a CSS file ? (Or: why site routes are not children of the main "site" route ?)

[jajm]

Trying to see if I'm not missing something here, but it seems that if site routes were children of the main "site" route, the site theme style would be automatically applied to Scripto pages, and we wouldn't need to copy a CSS file inside Scripto module folder.

(for reference, I'm talking about this: https://omeka.org/s/docs/user-manual/modules/scripto/themeingScripto/)

And because of that, we also cannot have some site features (like the site navigation or the ability for themes to override view templates)

I see that these pages use their own layout for navigation and that may be challenging to do in a theme-agnostic way, but aside from that, is there other reasons to keep it this way ?

[jimsafley]

It's been a long time, but from what I remember we decided on this approach because we imagined the public Scripto interface as a separate application from the site. Given the complexity of its user interface and workflow, we isolated Scripto into a separate route to have reliable control over its style and to keep it consistent from one theme to another.

[jajm]

Thanks for the quick answer.
Given it was a deliberate decision, is it safe to assume you won't accept any PR that moves Scripto pages into the site ? (which is fine by me, I only want to be sure)

[jajm]

FYI I'm testing things on this branch : https://github.com/biblibre/omeka-s-module-Scripto/tree/move-public-app-to-site
Moving the routes under the site route can be done while keeping the same appearance and it also allows themes to override view templates (including the scripto layout so it allows themes to add their own CSS and to put site navigation somewhere in the pages)

[jimsafley]

I appreciate your work on this. There's no harm in submitting a PR, though reviewing and testing it would not be high on our priorities.