Skip to content

RFC-4: review 3 #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clbarnes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RFC-4: review 3 #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions rfc/4/reviews/3/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# RFC-4: Review 2

## Review authors

Chris Barnes <chris.barnes@gerbi-gmb.de>

## Conflicts of interest

None.

## Summary

Orientation is a useful piece of metadata which is easy to mistake through various registration and transformation steps.
This RFC is sufficiently flexible to allow extension to different orientation types in future,
while being simple to implement for the enumeration listed here.

## Significant comments and questions

N/A

## Minor comments and questions

Hyphens here are used as they would be in English.
If/when the set of acceptable orientations is extended,
we should be cautious that the existing hyphenated terms are not mistaken as a `kebab-case` convention;
OME-Zarr uses `camelCase` and Zarr uses `snake_case` for multi-word keys.

## Recommendation

Accept.
Loading