From 5161bf0630832e015fc9046924dc3e7a1354bbc3 Mon Sep 17 00:00:00 2001 From: Per Karlstrom Date: Tue, 24 Mar 2026 18:35:32 +0000 Subject: [PATCH 1/2] vcs: Scope parameter assignments to toplevel module Parameter assignments in parameters.txt need to be qualified with the toplevel module name to work correctly with VCS simulation. Co-Authored-By: Claude Opus 4.6 --- edalize/tools/vcs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/edalize/tools/vcs.py b/edalize/tools/vcs.py index b5d8fd4e..ec0339e7 100644 --- a/edalize/tools/vcs.py +++ b/edalize/tools/vcs.py @@ -273,7 +273,7 @@ def write_config_files(self): s = "" for key, value in _parameters.items(): _value = self._param_value_str(value, '"') - s += f"assign {_value} {key}\n" + s += f"assign {_value} {self.toplevel}.{key}\n" self.update_config_file("parameters.txt", s) def run(self): From 18d90dfea04e1791e17e137a3274bfb6034c6d24 Mon Sep 17 00:00:00 2001 From: Per Karlstrom Date: Tue, 24 Mar 2026 18:41:29 +0000 Subject: [PATCH 2/2] update test refernce files --- tests/tools/vcs/2stage_basic/parameters.txt | 6 +++--- tests/tools/vcs/basic/parameters.txt | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/tools/vcs/2stage_basic/parameters.txt b/tests/tools/vcs/2stage_basic/parameters.txt index 9363f77f..dcadfe36 100644 --- a/tests/tools/vcs/2stage_basic/parameters.txt +++ b/tests/tools/vcs/2stage_basic/parameters.txt @@ -1,3 +1,3 @@ -assign 1 vlogparam_bool -assign 42 vlogparam_int -assign "hello" vlogparam_str +assign 1 top_module.vlogparam_bool +assign 42 top_module.vlogparam_int +assign "hello" top_module.vlogparam_str diff --git a/tests/tools/vcs/basic/parameters.txt b/tests/tools/vcs/basic/parameters.txt index 9363f77f..dcadfe36 100644 --- a/tests/tools/vcs/basic/parameters.txt +++ b/tests/tools/vcs/basic/parameters.txt @@ -1,3 +1,3 @@ -assign 1 vlogparam_bool -assign 42 vlogparam_int -assign "hello" vlogparam_str +assign 1 top_module.vlogparam_bool +assign 42 top_module.vlogparam_int +assign "hello" top_module.vlogparam_str