Commit 2a9baec
authored
Fix #92priv: [Bug] Volume DF DCV bounds (#809)
Fix df-private#92: [Bug] Volume DF's DCV bounds are per user & per-asset, should only be per-asset
- wrote a special test to catch the issue: `test_bound_by_DCV_1nft_2accounts()`. The test was failing (as it should have been)
- then fixed the issue: just one line in df_py/volume/reward_calculator.py. This made the failing test pass (good)
- also, a couple other tests in df_py/volume/test/test_calcrewards.py were failing: test_volume_reward_calculator() and test_volume_reward_calculator_predictoor_mul(). I refactored them to be more compact, then fixed the failures1 parent cca4665 commit 2a9baec
File tree
2 files changed
+131
-139
lines changed- df_py/volume
- test
2 files changed
+131
-139
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
204 | | - | |
| 204 | + | |
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
| |||
0 commit comments