Release rddi 0.1.0

[psanker]

First release:

• usethis::use_cran_comments()
• Update (aspirational) install instructions in README
• Proofread Title: and Description:
• Check that all exported functions have @return and @examples
• Check that Authors@R: includes a copyright holder (role 'cph')
• Check licensing of included files
• Review https://github.com/DavisVaughan/extrachecks

Prepare for release:

• devtools::build_readme()
• urlchecker::url_check()
• devtools::check(remote = TRUE, manual = TRUE)
• devtools::check_win_devel()
• rhub::check_for_cran()
• Draft blog post

Submit to CRAN:

• usethis::use_version('minor')
• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• usethis::use_github_release()
• usethis::use_dev_version()
• usethis::use_news_md()
• Finish blog post
• Tweet
• Add link to blog post in pkgdown news menu

[psanker]

Two issues need to be resolved:

• @return and @examples need to filled out for all exported members.
• A DDI URI seems to be malformed. Check that URI with urlchecker::url_check() and see if there's a redirect that happens (see: https://github.com/DavisVaughan/extrachecks/blob/master/README.md)

[dswoulf]

Fixed the DDI URI...it was just a double bracket {{}} instead of a single one around the URL. Not sure why the others are getting flagged though. I've tried to replicate the issue using devtools::check() but nothing has popped up. I've also tried checking the DDI website but it looks fine to me. No redirects or anything, although it is HTTP/1.1. From a little bit of research that shouldn't have an impact on it being https. See below:

curlGetHeaders("https://ddialliance.org")
 [1] "HTTP/1.1 200 OK\r\n"                                                                       
 [2] "Date: Sat, 14 May 2022 19:48:21 GMT\r\n"                                                   
 [3] "Server: Apache\r\n"                                                                        
 [4] "X-Content-Type-Options: nosniff\r\n"                                                       
 [5] "X-Powered-By: PHP/7.3.11\r\n"                                                              
 [6] "X-Drupal-Cache: HIT\r\n"                                                                   
 [7] "Etag: \"1652556546-0\"\r\n"                                                                
 [8] "Content-Language: en\r\n"                                                                  
 [9] "X-Frame-Options: SAMEORIGIN\r\n"                                                           
[10] "Permissions-Policy: interest-cohort=()\r\n"                                                
[11] "Cache-Control: public, max-age=3600\r\n"                                                   
[12] "Last-Modified: Sat, 14 May 2022 19:29:06 GMT\r\n"                                          
[13] "Expires: Sun, 19 Nov 1978 05:00:00 GMT\r\n"                                                
[14] "Vary: Cookie,Accept-Encoding\r\n"                                                          
[15] "Content-Type: text/html; charset=utf-8\r\n"                                                
[16] "Set-Cookie: LBSESSIONID=1409536909.47873.0000; path=/; Httponly; Secure; SameSite=none\r\n"
[17] "\r\n"                                                                                      
attr(,"status")
[1] 200

I'm kind of at a loss otherwise on how to handle the

Status: Error
    Message: libcurl error code 35:
      	schannel: failed to receive handshake, SSL/TLS connection failed

issue since I can't replicate it locally and no redirects are appearing. I see two ways forward: 1) resubmit and hope for the best or 2) replace the URLs with plain text. @psanker Thoughts?

[dswoulf]

I think create_object_id should be exported but I'm not really sure how it's used. It says it needs an object but you'd create it as an attribute right? ID = create_object_id()?

Otherwise malformed URL and other examples/returns fixes are complete. Still not sure why libcurl was giving an error the last CRAN check...

[psanker]

Maybe, since CRAN itself isn't throwing the error for curl, it'll be fine?