Scheme and List attributes present causes Warnings

[DemigodCode]

Is there any reason why those attributes are at e.g. TaxCategory ID?

All Validators are warning that that should not be present.

I can't upload the file to two Peppol Access Points.

[TSimkus]

Hey @DemigodCode

Are you talking about this in TaxCategory?

ubl-invoice/src/TaxCategory.php

Lines 47 to 54 in 3ee8087

	public function setId(?string $id, $attributes = null): TaxCategory
	{
	$this->id = $id;
	if (isset($attributes)) {
	$this->idAttributes = $attributes;
	}
	return $this;
	}

If so, at least I, do not see any references in the documentation that these attributes should be set.
But for now, you can pass an empty array for the $attribute parameter when setting id as a workaround:

$taxCategory = (new TaxCategory)
            ->setId(UNCL5305::STANDARD_RATE, [])

[kouinkouin]

Hello,

@DemigodCode , are you talking about the warning UBL-CR-678 ("A UBL invoice should not include the TaxCategory/ID schemeID")?
I use this document as reference: https://docs.peppol.eu/poacc/billing/3.0/2023-Q4/bis/ , you can search "UBL-CR-678".
I use this validator to validate my XML's: https://www.ubl.be/validator/ .

If yes, to solve this warning, I update the class NumNum\UBL\TaxScheme::xmlSerialize():

@@ -92,9 +92,11 @@ class TaxScheme implements XmlSerializable
      */
     public function xmlSerialize(Writer $writer): void
     {
-        $writer->write([
-            Schema::CBC . 'ID' => $this->id
-        ]);
+        if ($this->id !== null) {
+            $writer->write([
+                Schema::CBC . 'ID' => $this->id
+            ]);
+        }
         if ($this->name !== null) {
             $writer->write([
                 Schema::CBC . 'Name' => $this->name

[brtdv]

@DemigodCode Do you have an example generated XML and against what schematron are you validating?

[gwelr]

Using this validator: https://peppol-tools.ademico-software.com/ui/document-validator (select Peppol BIS Billing UBL Invoice V3), I have similar warnings.

EG:

    Error Level: WARNING
    Error Id: UBL-CR-661
    Schematron Test: not(cac:PaymentMeans/cbc:PaymentMeansCode/@listID)
    XPath: /Invoice[1]
    Error: [UBL-CR-661]-A UBL invoice should not include the PaymentMeansCode listID

[UBL-CR-661] means a UBL invoice should not include the PaymentMeansCode listID. It seems the listID attribute is explicitly forbidden by the Peppol BIS3 rules.

Below is an example PHP code:

            $paymentMeans = (new PaymentMeans())
                ->setPaymentMeansCode(31)  // UNCL4461 code for 'Credit Transfer'.
                ->setPayeeFinancialAccount($financialAccount);

            $ublInvoice->setPaymentMeans([$paymentMeans]);

And here is the related XML generated by the package:

 <cac:PaymentMeans>
  <cbc:PaymentMeansCode listID="UN/ECE 4461" listName="Payment Means" listURI="http://docs.oasis-open.org/ubl/os-UBL-2.0-update/cl/gc/default/PaymentMeansCode-2.0.gc">31</cbc:PaymentMeansCode>
  <cac:PayeeFinancialAccount>
...
  </cac:PayeeFinancialAccount>
 </cac:PaymentMeans>

I believe The corrected, compliant XML should be:

<cbc:PaymentMeansCode>31</cbc:PaymentMeansCode>

And I confirm that the workaround is working, but it is my understanding that the paymentMeansCodeAttributes could be left empty all together. See https://github.com/num-num/ubl-invoice/blob/master/src/PaymentMeans.php#L13C4-L16C112

Finally, I have similar warnings on the TaxCategory/ID schemeID.