bug: Categorizedview?

[PPN-SD]

System Details
OS: Gentoo Linux
Arch: x64
Desktop Environment: sway
Version: 3.4.0
Installed by: compiled

I noted that categorizedview is available again but I can't find it.
It was available before (but crash) with :
> library view > set group by album > sort by artist year album > set view categorized

Did I miss something?

[nullobsi]

Thanks for the bug report. Yes, you are correct. I mistook an ifndef for an ifdef when enabling the option permanently, so all the code is there, but it doesn't show up!

547f347#diff-558da7484530d7d395defd9c90ee75cb1929cf8f3b517970871783822d89cf1bL202

cantata/widgets/singlepagewidget.cpp

Lines 195 to 203 in c3a900e

	QList<QAction*> SinglePageWidget::createViewActions(QList<ItemView::Mode> modes)
	{
	QList<QPair<QString, int>> vals;
	for (ItemView::Mode m : modes) {
	if (m != ItemView::Mode_Categorized)
	vals.append(MenuItem(viewTypeString(m), m));
	}
	return createActions(vals, view->viewMode(), this, SLOT(viewModeSelected()));
	}

[nullobsi]

The linked PR enables categorized view, but it does have bugs (quick tests on macOS). If you could test it out, let me know if you run into any crashes (with stacktrace would be great!) let me know

[PPN-SD]

debug.txt