OffsetCommitRequest API implementation

[himanshuatjudo]

It seems I could find offset commit implementation, is there any idea when it will be released?

[vchekan]

There is no such plan, because my use case requires high reliability, so I store offsets on my own along with data. This way it is impossible for me to move offset ahead in zookeeper, and than fail saving processed data, which would cause a "gap" in data stream when process recovers.

But if anybody would like to implement it, I will be happy to help.

[avoxm]

@vchekan you can assign this to me. I will need offset commit/fetch API.

[vchekan]

@avoxm go for it.
Kafka protocol spec I used is here:
https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol

Low level serializer helper is here:
https://github.com/ntent-ad/kafka4net/blob/master/src/Protocols/Serializer.cs

API calls are implemented here:
https://github.com/ntent-ad/kafka4net/blob/master/src/Protocols/Protocol.cs

And than you will implement a user facing API in Consumer. Perhaps you will add a setting to a consumer configuration.

[avoxm]

@vchekan ok, so I have some time to work on this ....
Basically for each request type I need to do this :

1. In cluster.cs add 2 new methods one for each request type that will serve as a public interface for clients.
2. Add implementations in Protocol.cs
3. Add Serialize/Deserialize methods for each request type in Serializer.cs
4. Tests

Am I missing something ?

[vchekan]

Seems right

[chiru1205]

@avoxm , Did u ever implement Offset/Fetch API?