feat: add package manager select dropdown #379
+228
−117
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,192 @@ | ||
| <script setup lang="ts"> | ||
| import { onClickOutside, useEventListener } from '@vueuse/core' | ||
|
|
||
| const selectedPM = useSelectedPackageManager() | ||
|
|
||
| const listRef = useTemplateRef('listRef') | ||
| const triggerRef = useTemplateRef('triggerRef') | ||
| const isOpen = shallowRef(false) | ||
| const highlightedIndex = shallowRef(-1) | ||
|
|
||
| const dropdownPosition = shallowRef<{ top: number; left: number } | null>(null) | ||
|
|
||
| function getDropdownStyle(): Record<string, string> { | ||
| if (!dropdownPosition.value) return {} | ||
| return { | ||
| top: `${dropdownPosition.value.top}px`, | ||
| left: `${dropdownPosition.value.left}px`, | ||
| } | ||
| } | ||
|
|
||
| useEventListener('scroll', close, true) | ||
|
|
||
| // Generate unique ID for accessibility | ||
| const inputId = useId() | ||
| const listboxId = `${inputId}-listbox` | ||
|
|
||
| function toggle() { | ||
| if (isOpen.value) { | ||
| close() | ||
| } else { | ||
| if (triggerRef.value) { | ||
| const rect = triggerRef.value.getBoundingClientRect() | ||
| dropdownPosition.value = { | ||
| top: rect.bottom + 4, | ||
| left: rect.left, | ||
| } | ||
| } | ||
| isOpen.value = true | ||
| highlightedIndex.value = packageManagers.findIndex(pm => pm.id === selectedPM.value) | ||
| } | ||
| } | ||
|
|
||
| function close() { | ||
| isOpen.value = false | ||
| highlightedIndex.value = -1 | ||
| } | ||
|
|
||
| function select(id: PackageManagerId) { | ||
| selectedPM.value = id | ||
| close() | ||
| triggerRef.value?.focus() | ||
| } | ||
|
|
||
| // Check for reduced motion preference | ||
| const prefersReducedMotion = useMediaQuery('(prefers-reduced-motion: reduce)') | ||
|
|
||
| onClickOutside(listRef, close, { ignore: [triggerRef] }) | ||
| function handleKeydown(event: KeyboardEvent) { | ||
| if (!isOpen.value) return | ||
|
|
||
| switch (event.key) { | ||
| case 'ArrowDown': | ||
| event.preventDefault() | ||
| highlightedIndex.value = (highlightedIndex.value + 1) % packageManagers.length | ||
| break | ||
| case 'ArrowUp': | ||
| event.preventDefault() | ||
| highlightedIndex.value = | ||
| highlightedIndex.value <= 0 ? packageManagers.length - 1 : highlightedIndex.value - 1 | ||
| break | ||
| case 'Enter': { | ||
| event.preventDefault() | ||
| const pm = packageManagers[highlightedIndex.value] | ||
| if (pm) { | ||
| select(pm.id) | ||
| } | ||
| break | ||
| } | ||
| case 'Escape': | ||
| close() | ||
| triggerRef.value?.focus() | ||
| break | ||
| } | ||
| } | ||
| </script> | ||
|
|
||
| <template> | ||
| <button | ||
| ref="triggerRef" | ||
| type="button" | ||
| class="flex items-center gap-1.5 px-2 py-2 font-mono text-xs text-fg-muted bg-bg-subtle border border-border-subtle border-solid rounded-md transition-colors duration-150 hover:(text-fg border-border-hover) active:scale-95 focus:border-border-hover focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-fg/50 hover:text-fg" | ||
| :aria-expanded="isOpen" | ||
| aria-haspopup="listbox" | ||
| :aria-label="$t('package.get_started.pm_label')" | ||
| :aria-controls="listboxId" | ||
| @click="toggle" | ||
| @keydown="handleKeydown" | ||
| > | ||
| <template v-for="pmOption in packageManagers" :key="pmOption.id"> | ||
| <span | ||
| class="inline-block h-3 w-3 pm-select-content" | ||
| :class="pmOption.icon" | ||
| :data-pm-select="pmOption.id" | ||
| aria-hidden="true" | ||
| /> | ||
| <span | ||
| class="pm-select-content" | ||
| :data-pm-select="pmOption.id" | ||
| :aria-hidden="pmOption.id !== selectedPM" | ||
|
Contributor
Author
There was a problem hiding this comment. Not ideal that we generate DOM elements that aren't visible. I tried to mitigate it for screen readers with aria hidden, but I'm open to ideas! |
||
| >{{ pmOption.label }}</span | ||
| > | ||
| </template> | ||
| <span | ||
| class="i-carbon:chevron-down w-3 h-3" | ||
| :class="[ | ||
| { 'rotate-180': isOpen }, | ||
| prefersReducedMotion ? '' : 'transition-transform duration-200', | ||
| ]" | ||
| aria-hidden="true" | ||
| /> | ||
| </button> | ||
|
|
||
| <!-- Dropdown menu (teleported to body to avoid clipping) --> | ||
| <Teleport to="body"> | ||
|
Contributor
Author
There was a problem hiding this comment. I couldn't think of a better way to avoid clipping. But this means if JS is disabled you won't be able to open the dropdown. I checked in prod and currently you can't interact with the tabs with JS disabled. It's not great either way, let me know if this is a blocker! |
||
| <Transition | ||
| :enter-active-class="prefersReducedMotion ? '' : 'transition-opacity duration-150'" | ||
| :enter-from-class="prefersReducedMotion ? '' : 'opacity-0'" | ||
| enter-to-class="opacity-100" | ||
| :leave-active-class="prefersReducedMotion ? '' : 'transition-opacity duration-100'" | ||
| leave-from-class="opacity-100" | ||
| :leave-to-class="prefersReducedMotion ? '' : 'opacity-0'" | ||
| > | ||
| <ul | ||
| v-if="isOpen" | ||
| :id="listboxId" | ||
| ref="listRef" | ||
| role="listbox" | ||
| :aria-activedescendant=" | ||
| highlightedIndex >= 0 | ||
| ? `${listboxId}-${packageManagers[highlightedIndex]?.id}` | ||
| : undefined | ||
| " | ||
| :aria-label="$t('package.get_started.pm_label')" | ||
| :style="getDropdownStyle()" | ||
| class="fixed bg-bg-subtle border border-border rounded-md shadow-lg z-50" | ||
| > | ||
| <li | ||
| v-for="(pm, index) in packageManagers" | ||
| :id="`${listboxId}-${pm.id}`" | ||
| :key="pm.id" | ||
| role="option" | ||
| :aria-selected="selectedPM === pm.id" | ||
| class="flex items-center gap-2 px-3 py-1.5 font-mono text-xs cursor-pointer transition-colors duration-150" | ||
| :class="[ | ||
| selectedPM === pm.id ? 'text-fg' : 'text-fg-subtle', | ||
| highlightedIndex === index ? 'bg-bg-elevated' : 'hover:bg-bg-elevated', | ||
| ]" | ||
| @click="select(pm.id)" | ||
| @mouseenter="highlightedIndex = index" | ||
| > | ||
| <span class="inline-block h-3 w-3" :class="pm.icon" aria-hidden="true" /> | ||
| <span>{{ pm.label }}</span> | ||
| <span | ||
| v-if="selectedPM === pm.id" | ||
| class="i-carbon:checkmark w-3 h-3 text-accent ms-auto" | ||
| aria-hidden="true" | ||
| /> | ||
| </li> | ||
| </ul> | ||
| </Transition> | ||
| </Teleport> | ||
| </template> | ||
|
|
||
| <style> | ||
| :root[data-pm] .pm-select-content { | ||
| display: none; | ||
| } | ||
|
|
||
| :root[data-pm='npm'] [data-pm-select='npm'], | ||
| :root[data-pm='pnpm'] [data-pm-select='pnpm'], | ||
| :root[data-pm='yarn'] [data-pm-select='yarn'], | ||
| :root[data-pm='bun'] [data-pm-select='bun'], | ||
| :root[data-pm='deno'] [data-pm-select='deno'], | ||
| :root[data-pm='vlt'] [data-pm-select='vlt'] { | ||
| display: inline-block; | ||
| } | ||
|
|
||
| /* Fallback: when no data-pm is set, npm is selected by default */ | ||
| :root:not([data-pm]) .pm-select-content:not([data-pm-select='npm']) { | ||
| display: none; | ||
| } | ||
| </style> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to remove this if we think it's too crowded in the connector install area.