Skip to content

Improve UI elements #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
juhanikat wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Improve UI elements #923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99a88a7
change Grid to Grid2 in ArrayToTable, and remove marginBottom from ed…
juhanikat Aug 7, 2025
caec199
change import
juhanikat Aug 7, 2025
88db161
remove width from Grid
juhanikat Aug 7, 2025
6a25d3f
Change Box inside Grouped component to be a flex container, to fix ed…
juhanikat Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/DetailView/common/EditingModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const EditingModal = ({

return (
<Box>
<Button data-cy={dataCy} onClick={() => setOpen(true)} variant="contained" sx={{ marginBottom: '1em' }}>
<Button data-cy={dataCy} onClick={() => setOpen(true)} variant="contained">
{buttonText}
</Button>
<Modal
Expand Down
15 changes: 9 additions & 6 deletions frontend/src/components/DetailView/common/tabLayoutHelpers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Card, Typography, Box, Grid, Divider } from '@mui/material'
import { Card, Typography, Box, Divider } from '@mui/material'
import Grid from '@mui/material/Grid2'
import { ReactNode } from 'react'
import { useDetailContext } from '../Context/DetailContext'
import { EditDataType } from '@/shared/types'
Expand All @@ -11,14 +12,12 @@ export const ArrayToTable = ({ array, half }: { array: Array<Array<ReactNode>>;
return width
}
return (
<Grid container direction="row">
<Grid container direction="row" width={'100%'}>
{array.map((row, rowIndex) => (
<Grid key={rowIndex} container direction="row" minHeight="2.5em">
<Grid key={rowIndex} container direction="row" minHeight="2.5em" width={'100%'}>
{row.map((item, index) => (
<Grid
key={index}
item
xs={getCellWidth(rowIndex, index)}
sx={{
display: 'flex',
alignItems: 'center',
Expand All @@ -28,6 +27,7 @@ export const ArrayToTable = ({ array, half }: { array: Array<Array<ReactNode>>;
borderRight: '1px solid rgba(224, 224, 224, 1)',
}}
padding="5px"
size={getCellWidth(rowIndex, index)}
>
{typeof item === 'string' ? <b>{item}</b> : item}
</Grid>
Expand Down Expand Up @@ -94,6 +94,7 @@ export const Grouped = ({
borderColor: error ? 'red' : warning ? 'orange' : '',
borderRadius: error || warning ? 4 : '',
borderStyle: error || warning ? 'none none none solid' : '',
gap: '1em',
}

const titleColor = error ? 'red' : warning ? 'orange' : 'text.secondary'
Expand All @@ -108,7 +109,9 @@ export const Grouped = ({
<Divider />
</>
)}
<Box marginTop="15px">{children}</Box>
<Box marginTop="15px" gap={'2em'} sx={{ display: 'flex', flexDirection: 'column', gap: '1em' }}>
{children}
</Box>
</Card>
)
}
Expand Down
Loading