More robust forum webhook handling required

[FreneticScribbler]

So - I guess I made an assumption that nobody would remove the rig number from the automatically generated title from the 'add forum thread' button.

Clearly, I should never have relied on that assumption... Need to insert a hidden field with it in, or something (though I suppose this would still be user over writable). At the very least the code needs to more gracefully abort...

PyRIGS/RIGS/views/rigboard.py

Line 418 in 93762fe

event_id = int(body['topic']['title'][1:6]) # find the ID, force convert it to an int to eliminate leading zeros

Whoops.

[jb3]

Can we just regex for an event identifier in the title and do it that way?

I don't think we need to do much else smart, people can manually add a forum thread when editing the rig, if we want to we could search new post bodies for RIGS embeds?

Agree that it should gracefully handle.

This issue is manifesting as RIGS-29 in Sentry for those with access.

[FreneticScribbler]

Basing it on the embed would be better as people are much better trained to include that than to follow the sort-of-standardised 'rig number | rig title' format.

[jerbzz]

How would we deal with the case of multiple embeds of the same rig?

[jb3]

I think only adding a URL in if there is not already a URL is probably the safest way to do it.

We can also constrain by forum area etc. and also only look at top level posts?

[FreneticScribbler]

Pretty sure I already setup the webhook to only fire on top level posts in #rig-info