fix lowest computation wins algorithm

Author: Henry Hoegelow

CMakeLists.txt

@@ -24,10 +24,10 @@ add_library(reactive STATIC
         src/Var.cpp
 )
 
-if(CMAKE_BUILD_TYPE MATCHES "Debug")
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=address -fno-omit-frame-pointer")
-    set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fsanitize=address")
-endif()
+#if(CMAKE_BUILD_TYPE MATCHES "Debug")
+#    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=address -fno-omit-frame-pointer")
+#    set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fsanitize=address")
+#endif()
 
 target_include_directories(reactive PRIVATE ./src)
 target_include_directories(reactive PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/include)

include/reactive/Latch.h

@@ -24,9 +24,20 @@ namespace Reactive
         self.execute();
       }
 
-      Computation *getLowest(Computation *lowestSoFar) const override
+      Computation* getLowest(Computation* lowestSoFar) const override
       {
-        return self.m_dirty? self.m_computation.get() : nullptr;
+        if(!self.m_dirty)
+          self.resolveDirtynessDownstream();
+
+        if(!self.m_dirty)
+          return lowestSoFar;
+
+        auto my = self.m_computation.get();
+
+        if(!lowestSoFar)
+          return my;
+
+        return my->getDepth() < lowestSoFar->getDepth() ? lowestSoFar : my;
       }
     };
 

src/ComputationsImpl.cpp

@@ -57,4 +57,4 @@ namespace Reactive
         lowestSoFar = it->get();
     return lowestSoFar;
   }
-}  // namespace Reactive
+}