Skip to content

Migrate all test code from Groovy/Spock to Java/JUnit 5 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nokok wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Migrate all test code from Groovy/Spock to Java/JUnit 5 #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
192767f
Migrate all test code from Groovy/Spock to Java/JUnit 5
google-labs-jules[bot] Jun 12, 2025
acde457
Merge branch 'main' into feature/migrate-tests-to-junit5
nokok Jun 12, 2025
39d1ee7
Fix MethodResolverTest failures and update GitHub Actions
google-labs-jules[bot] Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ jobs:
uses: actions/setup-java@v4
with:
distribution: oracle
java-version: 24
java-version: 21
- name: build
run: ./gradlew clean build --no-daemon --refresh-dependencies
run: ./gradlew clean build --no-daemon --refresh-dependencies --stacktrace
18 changes: 8 additions & 10 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,22 @@ plugins {
id 'com.github.johnrengelman.shadow' version '8.1.1'
id 'java'
id 'application'
id 'groovy'
id 'antlr'
}

group 'net.nokok'
version '0.1'

tasks.withType(AbstractCompile)*.options*.encoding = tasks.withType(GroovyCompile)*.groovyOptions*.encoding = 'UTF-8'
tasks.withType(JavaCompile).configureEach { options.encoding = 'UTF-8' }

java {
toolchain {
languageVersion = JavaLanguageVersion.of(24)
languageVersion = JavaLanguageVersion.of(21)
}
}

sourceCompatibility = '24'
targetCompatibility = '24'
sourceCompatibility = '21'
targetCompatibility = '21'

repositories {
mavenCentral()
Expand All @@ -35,17 +34,16 @@ dependencies {
implementation group: 'org.ow2.asm', name: 'asm-util', version: asmVersion
implementation group: 'org.ow2.asm', name: 'asm-tree', version: asmVersion
implementation group: 'org.ow2.asm', name: 'asm-analysis', version: asmVersion
testImplementation group: 'org.spockframework', name: 'spock-core', version: '2.4-M6-groovy-4.0'
testImplementation group: 'junit', name: 'junit', version: '4.13.2'
testImplementation 'org.apache.groovy:groovy:4.0.27'
testImplementation 'org.apache.groovy:groovy-test:4.0.27'
testImplementation 'org.junit.jupiter:junit-jupiter-api:5.10.0'
testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.10.0'
testImplementation 'org.junit.jupiter:junit-jupiter-params:5.10.0'
}

test {
useJUnitPlatform()
testLogging {
events 'passed', 'failed', 'skipped'
}
jvmArgs '--enable-native-access=ALL-UNNAMED'
}

gradle.projectsEvaluated {
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.2-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
27 changes: 0 additions & 27 deletions src/test/groovy/org/karaffe/integration/PhasesSpec.groovy
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions src/test/groovy/org/karaffe/integration/ReportSpec.groovy
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions src/test/groovy/org/karaffe/regression/NPE.groovy
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions src/test/groovy/org/karaffe/regression/ReportSpec.groovy
View file
Open in desktop

This file was deleted.

63 changes: 0 additions & 63 deletions src/test/groovy/org/karaffe/unittests/ASTSpec.groovy
View file
Open in desktop

This file was deleted.

41 changes: 0 additions & 41 deletions src/test/groovy/org/karaffe/unittests/ArgSpec.groovy
View file
Open in desktop

This file was deleted.

36 changes: 0 additions & 36 deletions src/test/groovy/org/karaffe/unittests/ByteCodeSelectorSpec.groovy
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions src/test/groovy/org/karaffe/unittests/CompilerContextSpec.groovy
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions src/test/groovy/org/karaffe/unittests/FlagSpec.groovy
View file
Open in desktop

This file was deleted.

Loading