refactor: scope PR to extensions/ only

Remove Sandbox→Pod annotation propagation from sandbox_controller.go
per maintainer feedback. The in-place annotation/resource propagation
is a sig-apps design question and will be a separate follow-up.

This PR now only touches extensions/ (SandboxClaim workspaceResources).

Author: noeljackson

controllers/sandbox_controller.go

@@ -451,9 +451,6 @@ func (r *SandboxReconciler) reconcilePod(ctx context.Context, sandbox *sandboxv1
 		if pod.Labels == nil {
 			pod.Labels = make(map[string]string)
 		}
-		if pod.Annotations == nil {
-			pod.Annotations = make(map[string]string)
-		}
 		changed := false
 		if pod.Labels[sandboxLabel] != nameHash {
 			pod.Labels[sandboxLabel] = nameHash
@@ -466,12 +463,6 @@ func (r *SandboxReconciler) reconcilePod(ctx context.Context, sandbox *sandboxv1
 				changed = true
 			}
 		}
-		for k, v := range sandbox.Spec.PodTemplate.ObjectMeta.Annotations {
-			if pod.Annotations[k] != v {
-				pod.Annotations[k] = v
-				changed = true
-			}
-		}
 
 		// Set controller reference if the pod is not controlled by anything.
 		if controllerRef := metav1.GetControllerOf(pod); controllerRef == nil {

controllers/sandbox_controller_test.go

@@ -620,9 +620,6 @@ func TestReconcilePod(t *testing.T) {
 						"agents.x-k8s.io/sandbox-name-hash": nameHash,
 						"custom-label":                      "label-val",
 					},
-					Annotations: map[string]string{
-						"custom-annotation": "anno-val",
-					},
 					OwnerReferences: []metav1.OwnerReference{sandboxControllerRef(sandboxName)},
 				},
 				Spec: corev1.PodSpec{
@@ -702,7 +699,7 @@ func TestReconcilePod(t *testing.T) {
 			wantPod: nil,
 		},
 		{
-			name: "adopts existing pod via annotation - pod gets metadata and owner reference",
+			name: "adopts existing pod via annotation - pod gets label and owner reference",
 			initialObjs: []runtime.Object{
 				&corev1.Pod{
 					ObjectMeta: metav1.ObjectMeta{
@@ -730,11 +727,6 @@ func TestReconcilePod(t *testing.T) {
 				Spec: sandboxv1alpha1.SandboxSpec{
 					Replicas: ptr.To(int32(1)),
 					PodTemplate: sandboxv1alpha1.PodTemplate{
-						ObjectMeta: sandboxv1alpha1.PodMetadata{
-							Annotations: map[string]string{
-								"example.com/workspace": "true",
-							},
-						},
 						Spec: corev1.PodSpec{
 							Containers: []corev1.Container{
 								{
@@ -753,9 +745,6 @@ func TestReconcilePod(t *testing.T) {
 					Labels: map[string]string{
 						sandboxLabel: nameHash,
 					},
-					Annotations: map[string]string{
-						"example.com/workspace": "true",
-					},
 					OwnerReferences: []metav1.OwnerReference{sandboxControllerRef(sandboxName)},
 				},
 				Spec: corev1.PodSpec{
@@ -808,9 +797,6 @@ func TestReconcilePod(t *testing.T) {
 						"agents.x-k8s.io/sandbox-name-hash": nameHash,
 						"custom-label":                      "label-val",
 					},
-					Annotations: map[string]string{
-						"custom-annotation": "anno-val",
-					},
 					// Should still have the original controller reference
 					OwnerReferences: []metav1.OwnerReference{
 						{

extensions/api/v1alpha1/zz_generated.deepcopy.go

@@ -1298,7 +1298,7 @@ func TestSandboxClaimAdoptionAppliesWorkspaceResources(t *testing.T) {
 				ObjectMeta: sandboxv1alpha1.PodMetadata{
 					Annotations: map[string]string{
 						"example.com/workspace": "true",
-						"test-annotation":          "template",
+						"test-annotation":       "template",
 					},
 				},
 				Spec: corev1.PodSpec{