Fix storing entries in wrong list

fcturan20 · fcturan20 · commit a5ca50a34fc2 · 2025-07-08T19:03:24.000+03:00
diff --git a/Source/SettingsFileManager.cpp b/Source/SettingsFileManager.cpp
@@ -232,6 +232,11 @@ nosResult EntryManager::UpdateEntry(nos::Name pluginName, nos::util::SemVer plug
 		return updateEntry(entriesFromDifVersions.back().first);
 	};
 
-	return addOrUpdateEntry(LocalEntries[pluginName], dir);
+	std::unordered_map<nos::Name, ReadEntryList>& entriesMap = (dir == editor::SettingsEntryFileDirectory::LOCAL) ? LocalEntries :
+		(dir == editor::SettingsEntryFileDirectory::GLOBAL) ? GlobalEntries : WorkspaceEntries;
+	if (entriesMap.find(pluginName) == entriesMap.end()) {
+		nosEngine.LogE("Plugin %s is not registered for editor settings, but called UpdateEntry().", pluginName.AsCStr());
+	}
+	return addOrUpdateEntry(entriesMap[pluginName], dir);
 }
 }

Original file line number	Diff line number	Diff line change
`@@ -232,6 +232,11 @@ nosResult EntryManager::UpdateEntry(nos::Name pluginName, nos::util::SemVer plug`
`232`	`232`	`return updateEntry(entriesFromDifVersions.back().first);`
`233`	`233`	`};`
`234`	`234`
`235`		`- return addOrUpdateEntry(LocalEntries[pluginName], dir);`
	`235`	`+ std::unordered_map<nos::Name, ReadEntryList>& entriesMap = (dir == editor::SettingsEntryFileDirectory::LOCAL) ? LocalEntries :`
	`236`	`+ (dir == editor::SettingsEntryFileDirectory::GLOBAL) ? GlobalEntries : WorkspaceEntries;`
	`237`	`+ if (entriesMap.find(pluginName) == entriesMap.end()) {`
	`238`	`+ nosEngine.LogE("Plugin %s is not registered for editor settings, but called UpdateEntry().", pluginName.AsCStr());`
	`239`	`+ }`
	`240`	`+ return addOrUpdateEntry(entriesMap[pluginName], dir);`
`236`	`241`	`}`
`237`	`242`	`}`