Replies: 2 comments 7 replies
-
|
Why would you enable test configuration flags if you dont want to run tests? The right behavior is to have multiple config files. |
Beta Was this translation helpful? Give feedback.
-
|
In our last team meeting, we discussed automatically enabling "test" mode when any test-runner flags are set; it seemed to have good reception within the team. I'm nearly done with the proposal we mentioned (I juuust didn't have enough time to finish it before my trip), which touches on this.
This was exactly our thinking :) |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hey folks,
After this PR landed, any configuration under the
testnamespace now causes the--testflag to be automatically enabled.For example, with a configuration like:
{ "test": { "test-concurrency": 1, "experimental-test-coverage": true } }Node automatically treats
--testas provided.While this behavior makes total sense for different namespaces (like
permissions), for the test runner, IMHO, it adds some complexity.I would normally expect to define test runner configurations (e.g., exclusions, inclusions, global setups, etc.) in the config file, but only enable tests when I explicitly provide
--test.Currently, the intended way to disable it is by explicitly setting:
{ "test": { "test": false, "test-concurrency": 1, "experimental-test-coverage": true } }From my perspective, this devEx is suboptimal for this specific use case.
Therefore, I was thinking about introducing a way to differentiate the default behavior of specific namespaces, so the test runner configuration could be recognized but only enabled when explicitly triggered.
What do you think?
@nodejs/test_runner @JakobJingleheimer @marco-ippolito
Beta Was this translation helpful? Give feedback.
All reactions