patch-the-fox fails early at unzip.

[ewtoombs]

The newest versions you posted of the script read if [ "$status" -ne 0 ]; then instead of if [ "$status" -ne 2 ]; then, like the original version did. That causes the script to halt early, even if the unzip command succeeds. Here's my version. (I couldn't help but make a few other modifications. They aren't as important, though. And the patch itself is completely different. Just ignore that bit.)

#!/bin/bash

# Causes ctrl-T to make new windows instead of tabs in firefox.

set -e

tempdir="$(mktemp --tmpdir -d patch-the-fox.XXXX)"
mkdir "$tempdir/extract"
pushd "$tempdir/extract"

set +e
unzip /usr/lib/firefox/browser/omni.ja; res="$?"
if [ "$res" -ne 2 ]; then
  echo >&2 "Unexpected exit code from unzip: $res"
  exit "$res"
fi
set -e
patch -p0 <<EOF
--- chrome/browser/content/browser/browser.xhtml-	2010-01-01 00:00:00.000000000 +0000
+++ chrome/browser/content/browser/browser.xhtml	2020-06-04 13:25:15.312315566 +0000
@@ -279,7 +279,7 @@
          command="cmd_newNavigator"
          modifiers="accel" reserved="true"/>
     <key id="key_newNavigatorTab" data-l10n-id="tab-new-shortcut" modifiers="accel"
-         command="cmd_newNavigatorTabNoEvent" reserved="true"/>
+         command="cmd_newNavigator" reserved="true"/>
     <key id="focusURLBar" data-l10n-id="location-open-shortcut" command="Browser:OpenLocation"
          modifiers="accel"/>
     <key id="focusURLBar2" data-l10n-id="location-open-shortcut-alt" command="Browser:OpenLocation"
EOF
zip -qr9XD ../omni.ja *
sudo cp "$tempdir/omni.ja" /usr/lib/firefox/browser
find ~/.cache/mozilla/firefox -type d -name startupCache -exec rm -rf {} \;
popd
rm -r "$tempdir"

[SebastianSimon]

Over at my repo, I also tamper with the omni.ja file. Forget about the status code, check if the files got extracted instead. This is how I handle it — I also hide the extra bytes error and warning (see the first and second issue for more details):

firefox_dir="$(whereis firefox | cut --delimiter=' ' --fields=2)"

function unzip_without_expected_errors(){
  local -r unzip_errors="$(unzip -qq -d omni -- "${firefox_dir}/browser/omni.ja" 2>&1)"
  local -r expected_errors='^warning.+?\[.*?omni\.ja\]:.+?[1-9][0-9]*.+?extra.+?bytes.+?attempting.+?anyway.+?error.+?\[.*?omni\.ja\]:.+?reported.+?length.+?-[1-9][0-9]*.+?bytes.+?long.+?Compensating\.{3}$'
  
  if ! (shopt -s nullglob; unzipped_files=(*); ((${#unzipped_files[@]}))); then
    echo
    echo "$(tput setaf 9)Unexpected warning(s) or error(s) in unzip; terminating.$(tput sgr 0)" >&2
    echo "${unzip_errors}" >&2
    #Use your rm calls, popd, etc. here or at the `|| exit` below.
    
    return 1
  fi
  
  if [[ "${unzip_errors}" ]] && ! (echo "${unzip_errors}" | xargs | grep --extended-regexp --quiet -- "${expected_errors}"); then
    echo
    echo "Note: unexpected warning(s) or error(s) in unzip:"
    echo "${unzip_errors}"
    echo
  fi
  
  return 0
}

unzip_without_expected_errors || exit