-
-
Notifications
You must be signed in to change notification settings - Fork 25
Open
Labels
Description
Describe the Bug
It's not possible to configure the BASE_URL for a domain starting with board, becouse https://board.myproject.com contains /board and the function checkBaseUrl of file run.js do this:
function checkBaseUrl() {
const baseUrl = process.env.BASE_URL;
if (baseUrl) {
if (baseUrl.includes('/board')) {
return error('env.BASE_URL must point to the root of the webapp');
}I think that you can change the code to first check if the baseUrl format is not valid, then check why, somethink like this:
function checkBaseUrl() {
const baseUrl = process.env.BASE_URL;
if (baseUrl && !baseUrl.match(/^https?:\/\/(\.?\w+)+$/)) {
if (baseUrl.includes('/board')) {
return error('env.BASE_URL must point to the root of the webapp');
}Steps to Reproduce
try to configure the BASE_URL for a domain starting with board
Environment
- Host (Browser/Node version), if applicable: [e.g. MS Edge 18, Chrome 69, Node 10 LTS]
- OS: [e.g. Windows 7]
- Board version: [e.g. 1.0.0]