Skip to content

Review feedback #1

@nieldw

Description

@nieldw

I received the following, high level, feedback:

Positive

- Some separation of concern.
- Good unit test coverage.

Negative (Major)

- The solution does not work fully.
- Why mixing Kotlin and Java? It actually brings performance issues, rather than having one single language support (either Java or Kotlin).
- Inline regular expression definition (e.g., line 43 of class MultiLineKnapsackProblemParser).
- Code has big maintainability issue (e.g., class ZeroOneKnapsackSolver), he tried to have a relatively micro separation of concern, but none of the classes tells the clear intent of usage

I hope you can find yourself in the feedback provided...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions